Do not consume Alt-Shift-Up event for IME switch.

Do not consume Alt-Shift-Up event for IME switch.

To be compatible with Windows, Alt-Shift-Up key event should not be
consumed by ASH even it fires IME switch.

BUG=387583
TEST=manual and try bots

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279667

[Seigo Nonaka, 2014-06-23 12:22:53]

Hi Oshima, Shu,

could you take a look at this CL?

Oshima:
chrome/browser/ui/ash/ime_controller_chromeos.cc

Shu:
Other IME files.

Thanks

[Shu Chen, 2014-06-24 00:48:49]

I'm a little concerned that SwitchToNextInputMethod() returns void but
SwitchToPreviousInputMethod() returns bool.

Can you make them like a pair methods?

https://codereview.chromium.org/348293002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/348293002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:666: return;
This return is unnecessary.

https://codereview.chromium.org/348293002/diff/20001/chrome/browser/ui/ash/im...
File chrome/browser/ui/ash/ime_controller_chromeos.cc (right):

https://codereview.chromium.org/348293002/diff/20001/chrome/browser/ui/ash/im...
chrome/browser/ui/ash/ime_controller_chromeos.cc:20: return
manager->SwitchToPreviousInputMethod(accelerator);
Why not do the same as HandleNextIme()?

[Seigo Nonaka, 2014-06-24 04:35:01]

Sure, I missed that the HandleNextIme is also used in HandlePreviousIme.

I reverted all changes in InputMethodManagerImpl.
PTAL?

https://codereview.chromium.org/348293002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/348293002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:666: return;
On 2014/06/24 00:48:49, Shu Chen wrote:
> This return is unnecessary.

Done.

https://codereview.chromium.org/348293002/diff/20001/chrome/browser/ui/ash/im...
File chrome/browser/ui/ash/ime_controller_chromeos.cc (right):

https://codereview.chromium.org/348293002/diff/20001/chrome/browser/ui/ash/im...
chrome/browser/ui/ash/ime_controller_chromeos.cc:20: return
manager->SwitchToPreviousInputMethod(accelerator);
HandlePreviousIme is bound to "Ctrl-Space".
If we don't consume Ctrl-Space key event, the whitespace will be inserted into
text field.

On 2014/06/24 00:48:49, Shu Chen wrote:
> Why not do the same as HandleNextIme()?

[Shu Chen, 2014-06-24 05:27:59]

lgtm

[oshima, 2014-06-24 20:26:14]

lgtm

[Seigo Nonaka, 2014-06-25 03:36:29]

The CQ bit was checked by nona@chromium.org

[commit-bot: I haz the power, 2014-06-25 03:38:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nona@chromium.org/348293002/80001

[Seigo Nonaka, 2014-06-25 05:07:07]

The CQ bit was unchecked by nona@chromium.org

[Seigo Nonaka, 2014-06-25 05:07:31]

The CQ bit was checked by nona@chromium.org

[commit-bot: I haz the power, 2014-06-25 05:09:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nona@chromium.org/348293002/100001

[commit-bot: I haz the power, 2014-06-25 10:25:23]

Change committed as 279667