Do not consume Alt-Shift-Up event for IME switch.

chrome/browser/chromeos/input_method/input_method_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/input_method/input_method_manager_impl.h"
 
 #include <algorithm>  // std::find
 
 #include "ash/ime/input_method_menu_item.h"
 #include "ash/ime/input_method_menu_manager.h"
@@ skipping 625 matching lines @@
     if (initial_input_method_id.empty()) {
       // If kPreferredKeyboardLayout is not specified, use the hardware layout.
       input_methods_to_be_enabled = util_.GetHardwareLoginInputMethodIds();
     } else {
       input_methods_to_be_enabled.push_back(initial_input_method_id);
     }
     EnableLoginLayouts(locale, input_methods_to_be_enabled);
   }
 }
 
-bool InputMethodManagerImpl::SwitchToNextInputMethod() {
+void InputMethodManagerImpl::SwitchToNextInputMethod() {
   // Sanity checks.
   if (active_input_method_ids_.empty()) {
     DVLOG(1) << "active input method is empty";
-    return false;
+    return;
   }
 
   if (current_input_method_.id().empty()) {
     DVLOG(1) << "current_input_method_ is unknown";
-    return false;
+    return;
   }
 
   // Do not consume key event if there is only one input method is enabled.
   // Ctrl+Space or Alt+Shift may be used by other application.
   if (active_input_method_ids_.size() == 1)
-    return false;
+    return;
 
   // Find the next input method and switch to it.
   SwitchToNextInputMethodInternal(active_input_method_ids_,
                                   current_input_method_.id());
-  return true;
+  return;

[Shu Chen, 2014/06/24 00:48:49]

This return is unnecessary.

[Seigo Nonaka, 2014/06/24 04:35:01]

Done.

 }
 
 bool InputMethodManagerImpl::SwitchToPreviousInputMethod(
     const ui::Accelerator& accelerator) {
   // Sanity check.
   if (active_input_method_ids_.empty()) {
     DVLOG(1) << "active input method is empty";
     return false;
   }
 
   // Do not consume key event if there is only one input method is enabled.
   // Ctrl+Space or Alt+Shift may be used by other application.
   if (active_input_method_ids_.size() == 1)
     return false;
 
   if (accelerator.type() == ui::ET_KEY_RELEASED)
     return true;
 
   if (previous_input_method_.id().empty() ||
       previous_input_method_.id() == current_input_method_.id()) {
-    return SwitchToNextInputMethod();
+    SwitchToNextInputMethod();
+    return true;
   }
 
   std::vector<std::string>::const_iterator iter =
       std::find(active_input_method_ids_.begin(),
                 active_input_method_ids_.end(),
                 previous_input_method_.id());
   if (iter == active_input_method_ids_.end()) {
     // previous_input_method_ is not supported.
-    return SwitchToNextInputMethod();
+    SwitchToNextInputMethod();
+    return true;
   }
   ChangeInputMethodInternal(*iter, true);
   return true;
 }
 
 bool InputMethodManagerImpl::SwitchInputMethod(
     const ui::Accelerator& accelerator) {
   // Sanity check.
   if (active_input_method_ids_.empty()) {
     DVLOG(1) << "active input method is empty";
@@ skipping 206 matching lines @@
       CandidateWindowController::CreateCandidateWindowController());
   candidate_window_controller_->AddObserver(this);
 }
 
 Profile* InputMethodManagerImpl::GetProfile() const {
   return ProfileManager::GetActiveUserProfile();
 }
 
 }  // namespace input_method
 }  // namespace chromeos