Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 348203002: [IndexedDB] Removed FIXMEs as consistent enums being used on both sides of IPC. (Closed)

Created:
6 years, 6 months ago by Pritam Nikam
Modified:
6 years, 6 months ago
CC:
abarth-chromium, alecflett, blink-reviews, cmumford, dglazkov+blink, dgrogan, ericu+idb_chromium.org, jamesr, jsbell+idb_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[IndexedDB] Removed FIXMEs as consistent enums being used on both sides of IPC. Removed traces of typedefs from blink code: blink::WebIDBCursor::Direction blink::WebIDBDatabase::TaskType blink::WebIDBDatabase::PutMode blink::WebIDBDatabase::TransactionMode As below patches rolled out to use consistent enums on browser and blink side. Chromium side: https://codereview.chromium.org/320833002 Blink side: https://codereview.chromium.org/325683002 BUG=381848 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M public/platform/WebIDBCursor.h View 1 chunk +0 lines, -8 lines 0 comments Download
M public/platform/WebIDBDatabase.h View 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Pritam Nikam
Hi jsbell! I've removed FIXMEs from blink side. Please have a look.
6 years, 6 months ago (2014-06-21 07:44:07 UTC) #1
jsbell
lgtm
6 years, 6 months ago (2014-06-21 14:12:05 UTC) #2
Pritam Nikam
The CQ bit was checked by pritam.nikam@samsung.com
6 years, 6 months ago (2014-06-21 18:22:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pritam.nikam@samsung.com/348203002/1
6 years, 6 months ago (2014-06-21 18:23:17 UTC) #4
jsbell
On 2014/06/21 18:23:17, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 6 months ago (2014-06-21 19:30:31 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-21 19:34:19 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-21 19:36:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/8218)
6 years, 6 months ago (2014-06-21 19:36:40 UTC) #8
abarth-chromium
LGTM
6 years, 6 months ago (2014-06-21 19:57:14 UTC) #9
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-21 19:57:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pritam.nikam@samsung.com/348203002/1
6 years, 6 months ago (2014-06-21 19:57:59 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-21 20:21:51 UTC) #12
Message was sent while issue was closed.
Change committed as 176689

Powered by Google App Engine
This is Rietveld 408576698