Use SkMutex::assertHeld in SkPDFFont and SkPDFShader.

Use SkMutex::assertHeld in SkPDFFont and SkPDFShader.

Committed: https://skia.googlesource.com/skia/+/24480bc71ef6c754030cb3f98672da1c8fb3a63b

[hal.canary, 2014-06-20 17:33:24]

ptal

[mtklein, 2014-06-20 17:40:59]

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFFont.cpp
File src/pdf/SkPDFFont.cpp (right):

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFFont.cpp#newcod...
src/pdf/SkPDFFont.cpp:876: // This initialization is only thread safe with gcc,
so hold the mutex.
It's not even safe in Chromium.  They disable the feature that makes it so. 
Maybe just delete the comments?

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFShader.cpp
File src/pdf/SkPDFShader.cpp (right):

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFShader.cpp#newc...
src/pdf/SkPDFShader.cpp:605: SkPDFShader::CanonicalShadersMutex().assertHeld();
Seems redundant?  Just let CanonicalShaders() do it?

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFShader.cpp#newc...
src/pdf/SkPDFShader.cpp:639: SkPDFShader::CanonicalShadersMutex().assertHeld();
Ditto.

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFShader.cpp#newc...
src/pdf/SkPDFShader.cpp:672: // This initialization is only thread safe with gcc
or when
Again, misleading.  Let's just delete all these "is only thread safe" comments.

[mtklein, 2014-06-20 17:40:59]

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFShader.cpp
File src/pdf/SkPDFShader.cpp (right):

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFShader.cpp#newc...
src/pdf/SkPDFShader.cpp:639: SkPDFShader::CanonicalShadersMutex().assertHeld();
Ditto.

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFShader.cpp#newc...
src/pdf/SkPDFShader.cpp:672: // This initialization is only thread safe with gcc
or when
Again, misleading.  Let's just delete all these "is only thread safe" comments.

[hal.canary, 2014-06-20 17:49:07]

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFFont.cpp
File src/pdf/SkPDFFont.cpp (right):

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFFont.cpp#newcod...
src/pdf/SkPDFFont.cpp:876: // This initialization is only thread safe with gcc,
so hold the mutex.
On 2014/06/20 17:40:54, mtklein wrote:
> It's not even safe in Chromium.  They disable the feature that makes it so. 
> Maybe just delete the comments?

Done.

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFShader.cpp
File src/pdf/SkPDFShader.cpp (right):

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFShader.cpp#newc...
src/pdf/SkPDFShader.cpp:605: SkPDFShader::CanonicalShadersMutex().assertHeld();
On 2014/06/20 17:40:54, mtklein wrote:
> Seems redundant?  Just let CanonicalShaders() do it?

Done.

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFShader.cpp#newc...
src/pdf/SkPDFShader.cpp:639: SkPDFShader::CanonicalShadersMutex().assertHeld();
On 2014/06/20 17:40:56, mtklein wrote:
> Ditto.

Done.

https://codereview.chromium.org/348113002/diff/1/src/pdf/SkPDFShader.cpp#newc...
src/pdf/SkPDFShader.cpp:672: // This initialization is only thread safe with gcc
or when
On 2014/06/20 17:40:56, mtklein wrote:
> Again, misleading.  Let's just delete all these "is only thread safe"
comments.

Done.

[mtklein, 2014-06-20 17:49:38]

lgtm

[hal.canary, 2014-06-20 17:50:05]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-06-20 17:50:51]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/halcanary@google.com/348113002/20001

[commit-bot: I haz the power, 2014-06-20 18:28:51]

Change committed as 24480bc71ef6c754030cb3f98672da1c8fb3a63b