Issue 348083004: [Android] Disable download protection and client side detection services.

Issue 348083004: [Android] Disable download protection and client side detection services. (Closed)

Created:
6 years, 5 months ago by Feng Qian

Modified:
6 years, 5 months ago

Reviewers:
Yue Zhang, zysxqn, Scott Hess - ex-Googler

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Disable download protection and client side detection services. DownloadProtectionService is not used on Android. Android platform provides such protection. Disable the service and related unit tests in full safe browsing mode because TwoPhaseUploaderTest doesn't have test server support on Android. Also disable client side detection (CSD) service on Android, which isn't used at this point. Disable part of PhishingTermFeatureExtractorTest.ExtractFeatures test due to http://crbug.com/392234. The test tests the code used by CSD which is disabled on Android. BUG=381896 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281943

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : disable test and service #

Patch Set 4 : disable client side detection service #

Patch Set 5 : revert change in database_manager.h #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
M	chrome/browser/safe_browsing/safe_browsing_service.cc	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2	1 chunk	+6 lines, -0 lines	1 comment	Download
M	chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc	View	1 2 3	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

lgtm https://codereview.chromium.org/348083004/diff/80001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/348083004/diff/80001/chrome/chrome_tests_unit.gypi#newcode2655 chrome/chrome_tests_unit.gypi:2655: 'browser/safe_browsing/download_feedback_service_unittest.cc', Order 's' above 'u' in this section.

6 years, 5 months ago (2014-07-08 19:24:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/348083004/80001

6 years, 5 months ago (2014-07-08 21:55:10 UTC) #5

Message was sent while issue was closed.

Change committed as 281943

Expand Messages | Collapse Messages