Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10898)

Unified Diff: chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

Issue 348083004: [Android] Disable download protection and client side detection services. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert change in database_manager.h Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/chrome_tests_unit.gypi ('K') | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc
diff --git a/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc b/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc
index 0c1a056f28a5482ad52fb709ecad1d6f2378b1f9..c5075e5d1165bc7adcf5c3119dcf52ab1ade7392 100644
--- a/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc
+++ b/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc
@@ -257,6 +257,11 @@ TEST_F(PhishingTermFeatureExtractorTest, ExtractFeatures) {
ExpectFeatureMapsAreEqual(features, expected_features);
EXPECT_THAT(expected_shingle_hashes, testing::ContainerEq(shingle_hashes));
+#if !defined(OS_ANDROID)
+ // The test code is disabled due to http://crbug.com/392234
+ // The client-side detection feature is not enabled on Android yet.
+ // If we decided to enable the feature, we need to fix the bug first.
+
// Chinese translation of the phrase "hello goodbye hello goodbye". This tests
// that we can correctly separate terms in languages that don't use spaces.
page_text =
@@ -277,6 +282,7 @@ TEST_F(PhishingTermFeatureExtractorTest, ExtractFeatures) {
ASSERT_TRUE(ExtractFeatures(&page_text, &features, &shingle_hashes));
ExpectFeatureMapsAreEqual(features, expected_features);
EXPECT_THAT(expected_shingle_hashes, testing::ContainerEq(shingle_hashes));
+#endif
}
TEST_F(PhishingTermFeatureExtractorTest, Continuation) {
« chrome/chrome_tests_unit.gypi ('K') | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698