Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1407)

Issue 348083003: Revert of Notify the browser when the page lost interest about gamepads (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Notify the browser when the page lost interest about gamepads (https://codereview.chromium.org/345013002/) Reason for revert: Causing content_browsertest crashes on all platforms Original issue's description: > Notify the browser when the page lost interest about gamepads > > The page visibility logic used in NavigatorGamepad via DeviceEventControllerBase > assumes that we only want to tell the dispatcher that we are uninterested in > events if we have an event listener. This is not perfect for gamepad. If the > page doesn't add event listener for gamepad events it can still poll the data > via navigator.getGamepads() at which point we tell the browser that we need > gamepad data. We also want to tell the browser if we are not interested so that > it can suspend the polling thread. > Long story short, we shouldn't check m_hasEventListener in > pageVisibilityChanged. This CL doesn't change visible behavior thus no tests. > Visibility related tests should be added for gamepad though, I will do that > later. > > BUG=386846 > > R=bajones@chromium.org > TBR=abarth@chromium.org > > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176618 TBR=abarth@chromium.org,bajones@chromium.org,b.kelemen@samsung.com NOTREECHECKS=true NOTRY=true BUG=386846 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M Source/core/frame/DeviceEventControllerBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
Created Revert of Notify the browser when the page lost interest about gamepads
6 years, 6 months ago (2014-06-20 19:10:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/348083003/1
6 years, 6 months ago (2014-06-20 19:10:41 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 19:11:29 UTC) #3
Message was sent while issue was closed.
Change committed as 176635

Powered by Google App Engine
This is Rietveld 408576698