Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 348063002: undefok -> bool (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

undefok -> bool BUG=skia: not waiting for (dead?) win builder NOTRY=True Committed: https://skia.googlesource.com/skia/+/77a83962acf9211637d5ed0c81e1141a1ede05e1

Patch Set 1 #

Patch Set 2 : false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/flags/SkCommandLineFlags.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
6 years, 6 months ago (2014-06-20 14:56:45 UTC) #1
reed1
lgtm
6 years, 6 months ago (2014-06-20 14:58:11 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-20 15:05:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/348063002/20001
6 years, 6 months ago (2014-06-20 15:06:53 UTC) #4
reed1
The CQ bit was unchecked by reed@google.com
6 years, 6 months ago (2014-06-20 15:24:38 UTC) #5
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-20 15:24:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/348063002/20001
6 years, 6 months ago (2014-06-20 15:24:53 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 15:25:01 UTC) #8
Message was sent while issue was closed.
Change committed as 77a83962acf9211637d5ed0c81e1141a1ede05e1

Powered by Google App Engine
This is Rietveld 408576698