Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: tools/flags/SkCommandLineFlags.cpp

Issue 348063002: undefok -> bool (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: false Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/flags/SkCommandLineFlags.cpp
diff --git a/tools/flags/SkCommandLineFlags.cpp b/tools/flags/SkCommandLineFlags.cpp
index 9b31b657e56f435180b91653bae3edc2f148e3c7..42e9ebd971da2d59120b4a9b8f85e83b643c0c9a 100644
--- a/tools/flags/SkCommandLineFlags.cpp
+++ b/tools/flags/SkCommandLineFlags.cpp
@@ -8,7 +8,7 @@
#include "SkCommandLineFlags.h"
#include "SkTDArray.h"
-DEFINE_string(undefok, "", "Silently ignore unknown flags listed here instead of crashing.");
+DEFINE_bool(undefok, false, "Silently ignore unknown flags instead of crashing.");
bool SkFlagInfo::CreateStringFlag(const char* name, const char* shortName,
SkCommandLineFlags::StringArray* pStrings,
@@ -291,7 +291,7 @@ void SkCommandLineFlags::Parse(int argc, char** argv) {
while (stripped.startsWith('-')) {
stripped.remove(0, 1);
}
- if (!FLAGS_undefok.contains(stripped.c_str())) {
+ if (!FLAGS_undefok) {
SkDebugf("Got unknown flag \"%s\". Exiting.\n", argv[i]);
exit(-1);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698