Omnibox: Add Field Trial to Create UWYT When Inlining

chrome/browser/omnibox/omnibox_field_trial.h

Index: chrome/browser/omnibox/omnibox_field_trial.h
diff --git a/chrome/browser/omnibox/omnibox_field_trial.h b/chrome/browser/omnibox/omnibox_field_trial.h
index f6599eaf732a272e9277b2d589dca0932f0f3c5f..846ee31e0118dba67c3f58642ebc005c93c5f9f4 100644
--- a/chrome/browser/omnibox/omnibox_field_trial.h
+++ b/chrome/browser/omnibox/omnibox_field_trial.h
@@ -292,6 +292,23 @@ class OmniboxFieldTrial {
   static bool EnableAnswersInSuggest();
 
   // ---------------------------------------------------------
+  // For the AddUWYTMatchEvenIfPromotedURLs experiment that's part of the
+  // bundled omnibox field trial.
+
+  // Returns true if HistoryURL Provider should add the URL-what-you-typed match
+  // (if valid and reasonable) even if the provider has good inline
+  // autocompletions to offer.  Normally HistoryURL does not add the UWYT match
+  // if there are good inline autocompletions, as the user could simply hit
+  // backspace to delete the completion and get the what-you-typed match.
+  // However, in the disable inlining experiment this interaction is a lot more
+  // difficult.  The user will have to select a not-inlined suggestion and
+  // backspace (possibly a lot) to get back to the what-you-typed match.
+  // This mode is intended to alleviate the pain by always ensuring that
+  // the UWYT match appears somewhere on the list of suggestions.  Returns
+  // false if the experiment isn't active.

[Peter Kasting, 2014/06/20 21:12:42]

This all sort of confuses me.  It makes it sound like users may have to pick
some random selection number to get the WYT match.  But I thought the idea was,
when disable-inlining is on, we always want the WYT match to be default if the
user's input is a URL, so we'll provide the WYT and have the reorder code swap
it up as necessary.  If so, the comment doesn't really sound like that.

[Mark P, 2014/06/23 22:23:12]

This comment attempts to explain what happens when the disable inlining field
trial is active without this field trial being active.  It is a mess.  I've
removed that whole section and replaced it with a clearer single sentence.

+  static bool AddUWYTMatchEvenIfPromotedURLs();
+
+  // ---------------------------------------------------------
   // Exposed publicly for the sake of unittests.
   static const char kBundledExperimentFieldTrialName[];
   // Rule names used by the bundled experiment.
@@ -307,6 +324,7 @@ class OmniboxFieldTrial {
   static const char kBookmarksIndexURLsRule[];
   static const char kDisableInliningRule[];
   static const char kAnswersInSuggestRule[];
+  static const char kAddUWYTMatchEvenIfPromotedURLsRule[];
 
   // Parameter names used by the HUP new scoring experiments.
   static const char kHUPNewScoringEnabledParam[];