Omnibox: Add Field Trial to Create UWYT When Inlining

chrome/browser/omnibox/omnibox_field_trial.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 #define CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 274 matching lines @@
   // For the AnswersInSuggest experiment that's part of the bundled omnibox
   // field trial.
 
   // Returns true if the AnswersInSuggest feature should be enabled causing
   // query responses such as current weather conditions or stock quotes
   // to be provided in the Omnibox suggestion list. Considers both the
   // field trial state as well as the overriding command-line flags.
   static bool EnableAnswersInSuggest();
 
   // ---------------------------------------------------------
+  // For the AddUWYTMatchEvenIfPromotedURLs experiment that's part of the
+  // bundled omnibox field trial.
+
+  // Returns true if HistoryURL Provider should add the URL-what-you-typed match
+  // (if valid and reasonable) even if the provider has good inline
+  // autocompletions to offer.  Normally HistoryURL does not add the UWYT match
+  // if there are good inline autocompletions, as the user could simply hit
+  // backspace to delete the completion and get the what-you-typed match.
+  // However, in the disable inlining experiment this interaction is a lot more
+  // difficult.  The user will have to select a not-inlined suggestion and
+  // backspace (possibly a lot) to get back to the what-you-typed match.
+  // This mode is intended to alleviate the pain by always ensuring that
+  // the UWYT match appears somewhere on the list of suggestions.  Returns
+  // false if the experiment isn't active.

[Peter Kasting, 2014/06/20 21:12:42]

This all sort of confuses me.  It makes it sound like users may have to pick
some random selection number to get the WYT match.  But I thought the idea was,
when disable-inlining is on, we always want the WYT match to be default if the
user's input is a URL, so we'll provide the WYT and have the reorder code swap
it up as necessary.  If so, the comment doesn't really sound like that.

[Mark P, 2014/06/23 22:23:12]

This comment attempts to explain what happens when the disable inlining field
trial is active without this field trial being active.  It is a mess.  I've
removed that whole section and replaced it with a clearer single sentence.

+  static bool AddUWYTMatchEvenIfPromotedURLs();
+
+  // ---------------------------------------------------------
   // Exposed publicly for the sake of unittests.
   static const char kBundledExperimentFieldTrialName[];
   // Rule names used by the bundled experiment.
   static const char kShortcutsScoringMaxRelevanceRule[];
   static const char kSearchHistoryRule[];
   static const char kDemoteByTypeRule[];
   static const char kHQPBookmarkValueRule[];
   static const char kHQPDiscountFrecencyWhenFewVisitsRule[];
   static const char kHQPAllowMatchInTLDRule[];
   static const char kHQPAllowMatchInSchemeRule[];
   static const char kZeroSuggestRule[];
   static const char kZeroSuggestVariantRule[];
   static const char kBookmarksIndexURLsRule[];
   static const char kDisableInliningRule[];
   static const char kAnswersInSuggestRule[];
+  static const char kAddUWYTMatchEvenIfPromotedURLsRule[];
 
   // Parameter names used by the HUP new scoring experiments.
   static const char kHUPNewScoringEnabledParam[];
   static const char kHUPNewScoringTypedCountRelevanceCapParam[];
   static const char kHUPNewScoringTypedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringTypedCountScoreBucketsParam[];
   static const char kHUPNewScoringVisitedCountRelevanceCapParam[];
   static const char kHUPNewScoringVisitedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringVisitedCountScoreBucketsParam[];
 
@@ skipping 16 matching lines @@
   // prioritize different wildcard contexts, see the implementation.  How to
   // interpret the value is left to the caller; this is rule-dependent.
   static std::string GetValueForRuleInContext(
       const std::string& rule,
       AutocompleteInput::PageClassification page_classification);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
 };
 
 #endif  // CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_