Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 347953002: Use the same set of switches for service process autorun and for launching process from browser. (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Use the same set of switches for service process autorun and for launching process from browser. BUG=386897 TBR=rogerta NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278755

Patch Set 1 #

Patch Set 2 : Thu 06/19/2014 19:02:33.22 #

Total comments: 8

Patch Set 3 : Thu 06/19/2014 21:37:46.89 #

Patch Set 4 : Fri 06/20/2014 2:04:49.68 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -74 lines) Patch
M chrome/browser/service_process/service_process_control.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/service_process/service_process_control.cc View 1 2 3 chunks +6 lines, -49 lines 0 comments Download
M chrome/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/service_process_util.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/common/service_process_util.cc View 1 2 4 chunks +38 lines, -20 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-06-20 02:06:53 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/347953002/diff/20001/chrome/browser/service_process/service_process_control.cc File chrome/browser/service_process/service_process_control.cc (right): https://codereview.chromium.org/347953002/diff/20001/chrome/browser/service_process/service_process_control.cc#newcode126 chrome/browser/service_process/service_process_control.cc:126: scoped_ptr<CommandLine> cmd_line(CreateServiceProcessCommandLine()); base::CommandLine https://codereview.chromium.org/347953002/diff/20001/chrome/common/service_process_util.cc File chrome/common/service_process_util.cc (right): https://codereview.chromium.org/347953002/diff/20001/chrome/common/service_process_util.cc#newcode162 ...
6 years, 6 months ago (2014-06-20 02:50:30 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/347953002/diff/20001/chrome/browser/service_process/service_process_control.cc File chrome/browser/service_process/service_process_control.cc (right): https://codereview.chromium.org/347953002/diff/20001/chrome/browser/service_process/service_process_control.cc#newcode126 chrome/browser/service_process/service_process_control.cc:126: scoped_ptr<CommandLine> cmd_line(CreateServiceProcessCommandLine()); On 2014/06/20 02:50:29, Lei Zhang wrote: > ...
6 years, 6 months ago (2014-06-20 04:38:43 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-20 04:38:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/347953002/60001
6 years, 6 months ago (2014-06-20 04:42:47 UTC) #5
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-20 09:05:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/347953002/100001
6 years, 6 months ago (2014-06-20 09:09:56 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-20 09:21:12 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-20 09:21:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/347953002/100001
6 years, 6 months ago (2014-06-20 09:23:28 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 13:44:06 UTC) #11
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-20 16:09:09 UTC) #12
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-20 16:09:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/347953002/100001
6 years, 6 months ago (2014-06-20 16:10:04 UTC) #14
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-20 16:17:03 UTC) #15
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-20 16:17:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/347953002/100001
6 years, 6 months ago (2014-06-20 16:17:56 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 17:41:43 UTC) #18
Message was sent while issue was closed. 
Change committed as 278755

Powered by Google App Engine
This is Rietveld 408576698