Use the same set of switches for service process autorun and for launching process from browser.

chrome/common/service_process_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "chrome/common/service_process_util.h"
+
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/singleton.h"
 #include "base/path_service.h"
 #include "base/sha1.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/version.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
-#include "chrome/common/service_process_util.h"
+#include "components/cloud_devices/common/cloud_devices_switches.h"
 #include "content/public/common/content_paths.h"
+#include "google_apis/gaia/gaia_switches.h"
+#include "ui/base/ui_base_switches.h"
 
 #if !defined(OS_MACOSX)
 
 namespace {
 
 // This should be more than enough to hold a version string assuming each part
 // of the version string is an int64.
 const uint32 kMaxVersionStringLength = 256;
 
 // The structure that gets written to shared memory.
@@ skipping 111 matching lines @@
       *version = service_data->service_process_version;
     if (pid)
       *pid = service_data->service_process_pid;
     return true;
   }
   return false;
 }
 
 #endif  // !OS_MACOSX
 
+scoped_ptr<base::CommandLine> CreateServiceProcessCommandLine() {
+  base::FilePath exe_path;
+  PathService::Get(content::CHILD_PROCESS_EXE, &exe_path);
+  DCHECK(!exe_path.empty()) << "Unable to get service process binary name.";
+  scoped_ptr<base::CommandLine> command_line(new CommandLine(exe_path));

[Lei Zhang, 2014/06/20 02:50:29]

new base::CommandLine

[Vitaly Buka (NO REVIEWS), 2014/06/20 04:38:43]

Done.

+  command_line->AppendSwitchASCII(switches::kProcessType,
+                                  switches::kServiceProcess);
+  static const char* const kSwitches[] = {

[Lei Zhang, 2014/06/20 02:50:29]

kSwitchesToCopy?

[Vitaly Buka (NO REVIEWS), 2014/06/20 04:38:43]

Done.

+    switches::kCloudPrintSetupProxy,
+    switches::kCloudPrintURL,
+    switches::kCloudPrintXmppEndpoint,
+#if defined(OS_WIN)
+    switches::kEnableCloudPrintXps,
+#endif
+    switches::kEnableLogging,
+    switches::kIgnoreUrlFetcherCertRequests,
+    switches::kLang,
+    switches::kLoggingLevel,
+    switches::kLsoUrl,
+    switches::kNoServiceAutorun,
+    switches::kUserDataDir,
+    switches::kV,
+    switches::kVModule,
+    switches::kWaitForDebugger,
+  };
+
+  command_line->CopySwitchesFrom(*CommandLine::ForCurrentProcess(),

[Lei Zhang, 2014/06/20 02:50:29]

base::CommandLine

[Vitaly Buka (NO REVIEWS), 2014/06/20 04:38:43]

Done.

+                                 kSwitches, arraysize(kSwitches));
+  return command_line.Pass();
+}
+
 ServiceProcessState::ServiceProcessState() : state_(NULL) {
-  CreateAutoRunCommandLine();
+  autorun_command_line_ = CreateServiceProcessCommandLine();
   CreateState();
 }
 
 ServiceProcessState::~ServiceProcessState() {
 #if !defined(OS_MACOSX)
   if (shared_mem_service_data_.get()) {
     shared_mem_service_data_->Delete(GetServiceProcessSharedMemName());
   }
 #endif  // !OS_MACOSX
   TearDownState();
@@ skipping 74 matching lines @@
   shared_data->service_process_pid = base::GetCurrentProcId();
   shared_mem_service_data_.reset(shared_mem_service_data.release());
   return true;
 }
 
 IPC::ChannelHandle ServiceProcessState::GetServiceProcessChannel() {
   return ::GetServiceProcessChannel();
 }
 
 #endif  // !OS_MACOSX
-
-void ServiceProcessState::CreateAutoRunCommandLine() {
-  base::FilePath exe_path;
-  PathService::Get(content::CHILD_PROCESS_EXE, &exe_path);
-  DCHECK(!exe_path.empty()) << "Unable to get service process binary name.";
-  autorun_command_line_.reset(new CommandLine(exe_path));
-  autorun_command_line_->AppendSwitchASCII(switches::kProcessType,
-                                           switches::kServiceProcess);
-
-  // The user data directory is the only other flag we currently want to
-  // possibly store.
-  const CommandLine& browser_command_line = *CommandLine::ForCurrentProcess();
-  base::FilePath user_data_dir =
-    browser_command_line.GetSwitchValuePath(switches::kUserDataDir);
-  if (!user_data_dir.empty())
-    autorun_command_line_->AppendSwitchPath(switches::kUserDataDir,
-                                            user_data_dir);
-}