Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10915)

Unified Diff: chrome/test/nacl/nacl_browsertest.cc

Issue 347803004: Ensure the OSX crash catcher does not trigger on SIGABRT when disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/mac/os_crash_dumps.cc ('K') | « chrome/test/data/nacl/bad/ppapi_bad.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/nacl/nacl_browsertest.cc
diff --git a/chrome/test/nacl/nacl_browsertest.cc b/chrome/test/nacl/nacl_browsertest.cc
index cfbe37c65fe24b8f7057238e64dcc42c0310805d..377640d460a869e63331c545dd0ac7681169a007 100644
--- a/chrome/test/nacl/nacl_browsertest.cc
+++ b/chrome/test/nacl/nacl_browsertest.cc
@@ -87,9 +87,7 @@ NACL_BROWSER_TEST_F(NaClBrowserTest, ProgressEvents, {
// allowed. Also not run on GLibc because it's a large test that is at risk of
// causing timeouts.
// crbug/338444
-// crbug.com/375103: fails on Mac after open sourcing PDF plugin.
-// crbug.com/375103: fails on Linux too after open sourcing PDF plugin.
Mark Seaborn 2014/06/19 18:28:14 This issue seems unrelated, since Linux wouldn't b
Nick Bray (chromium) 2014/06/19 18:38:05 The only reason open sourcing the PDF plugin affec
Mark Seaborn 2014/06/19 22:14:32 OK, I see now. That wasn't obvious from the commi
-#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)
+#if defined(OS_WIN)
#define MAYBE_Bad DISABLED_Bad
#else
#define MAYBE_Bad Bad
« base/mac/os_crash_dumps.cc ('K') | « chrome/test/data/nacl/bad/ppapi_bad.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698