Ensure the OSX crash catcher does not trigger on SIGABRT when disabled.

base/mac/os_crash_dumps.cc

Index: base/mac/os_crash_dumps.cc
diff --git a/base/mac/os_crash_dumps.cc b/base/mac/os_crash_dumps.cc
index e50ac3974215d995be9eef7b4deeb4fe0d8c2e1a..380a4016d28e2fae399d9b2bc72a8e46b5922317 100644
--- a/base/mac/os_crash_dumps.cc
+++ b/base/mac/os_crash_dumps.cc
@@ -32,6 +32,7 @@ void DisableOSCrashDumps() {
   const int signals_to_intercept[] = {
     SIGILL,   // EXC_BAD_INSTRUCTION
     SIGTRAP,  // EXC_BREAKPOINT
+    SIGABRT,  // EXC_CRASH

[Mark Seaborn, 2014/06/19 18:28:14]

FWIW, the comment is misleading.

See
http://lackingrhoticity.blogspot.com/2013/08/handling-crashes-on-mac-os-x.html

Any hardware fault will trigger a Mach exception like EXC_BAD_INSTRUCTION,
EXC_ARITHMETIC, EXC_BAD_ACCESS, etc.

If the Mach exception handler passes the exception on, it gets converted to a
POSIX signal: SIGFPE, SIGBUS, etc.

If a POSIX signal is unhandled, it triggers the EXC_CRASH Mach exception.

So any fatal POSIX signal will be converted to EXC_CRASH.  SIGABRT is never
generated by a hardware fault, only by syscalls like kill() and raise().

So, can you write something like:
  const int signals_to_intercept[] = {
    // Hardware faults
    SIGILL,   // EXC_BAD_INSTRUCTION
    SIGTRAP,  // EXC_BREAKPOINT
    SIGFPE,   // EXC_ARITHMETIC
    SIGBUS,   // EXC_BAD_ACCESS
    SIGSEGV   // EXC_BAD_ACCESS
    // Not a hardware fault
    SIGABRT,
  };

[Nick Bray (chromium), 2014/06/19 20:49:55]

Done.

     SIGFPE,   // EXC_ARITHMETIC
     SIGBUS,   // EXC_BAD_ACCESS
     SIGSEGV   // EXC_BAD_ACCESS