Issue 347803003: Removed requirement that data reduction proxy key be non-empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347803003: Removed requirement that data reduction proxy key be non-empty (Closed)

Created:
6 years, 6 months ago by bengr

Modified:
6 years, 6 months ago

Reviewers:
marq (ping after 24h)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Removed requirement that data reduction proxy key be non-empty The removes a check on initialization, because the key may be set after initialization but before use. BUG=382977 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278596

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -32 lines)			Patch
	M	components/data_reduction_proxy/browser/data_reduction_proxy_params.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
	M	components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc	View		5 chunks	+4 lines, -25 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/347803003/1

6 years, 6 months ago (2014-06-19 17:26:11 UTC) #4

Message was sent while issue was closed.

Change committed as 278596