Removed requirement that data reduction proxy key be non-empty

components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_params.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "components/data_reduction_proxy/common/data_reduction_proxy_switches.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 182 matching lines @@
   CheckValues(params,
               kFlagKey,
               kFlagOrigin,
               kFlagFallbackOrigin,
               kFlagSSLOrigin,
               kFlagAltOrigin,
               kFlagAltFallbackOrigin,
               kFlagProbeURL);
 }
 
-TEST_F(DataReductionProxyParamsTest, FlagsNoKey) {
-  CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kDataReductionProxy, kFlagOrigin);
-  CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kDataReductionProxyFallback, kFlagFallbackOrigin);
-  CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kDataReductionSSLProxy, kFlagSSLOrigin);
-  CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kDataReductionProxyAlt, kFlagAltOrigin);
-  CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kDataReductionProxyAltFallback, kFlagAltFallbackOrigin);
-  CommandLine::ForCurrentProcess()->AppendSwitchASCII(
-      switches::kDataReductionProxyProbeURL, kFlagProbeURL);
-  TestDataReductionProxyParams params(
-      DataReductionProxyParams::kAllowed |
-      DataReductionProxyParams::kFallbackAllowed |
-      DataReductionProxyParams::kAlternativeAllowed |
-      DataReductionProxyParams::kPromoAllowed, HAS_EVERYTHING);
-  EXPECT_FALSE(params.init_result());
-}
-
 TEST_F(DataReductionProxyParamsTest, InvalidConfigurations) {
   const struct {
     bool allowed;
     bool fallback_allowed;
     bool alternative_allowed;
     bool promo_allowed;
     unsigned int missing_definitions;
     bool expected_result;
   } tests[]  = {
     { true, true, true, true, HAS_NOTHING, true },
-    { true, true, true, true, HAS_KEY, false },
+    { true, true, true, true, HAS_KEY, true },
     { true, true, true, true, HAS_DEV_ORIGIN, true },
     { true, true, true, true, HAS_ORIGIN, true },
     { true, true, true, true, HAS_ORIGIN | HAS_DEV_ORIGIN, false },
     { true, true, true, true, HAS_FALLBACK_ORIGIN, false },
     { true, true, true, true, HAS_SSL_ORIGIN, false },
     { true, true, true, true, HAS_ALT_ORIGIN, false },
     { true, true, true, true, HAS_ALT_FALLBACK_ORIGIN, false },
     { true, true, true, true, HAS_PROBE_URL, false },
 
     { true, false, true, true, HAS_NOTHING, true },
-    { true, false, true, true, HAS_KEY, false },
+    { true, false, true, true, HAS_KEY, true },
     { true, false, true, true, HAS_ORIGIN | HAS_DEV_ORIGIN, false },
     { true, false, true, true, HAS_FALLBACK_ORIGIN, true },
     { true, false, true, true, HAS_SSL_ORIGIN, false },
     { true, false, true, true, HAS_ALT_ORIGIN, false },
     { true, false, true, true, HAS_ALT_FALLBACK_ORIGIN, true },
     { true, false, true, true, HAS_PROBE_URL, false },
 
     { true, true, false, true, HAS_NOTHING, true },
-    { true, true, false, true, HAS_KEY, false },
+    { true, true, false, true, HAS_KEY, true },
     { true, true, false, true, HAS_ORIGIN | HAS_DEV_ORIGIN, false },
     { true, true, false, true, HAS_FALLBACK_ORIGIN, false },
     { true, true, false, true, HAS_SSL_ORIGIN, true },
     { true, true, false, true, HAS_ALT_ORIGIN, true },
     { true, true, false, true, HAS_ALT_FALLBACK_ORIGIN, true },
     { true, true, false, true, HAS_PROBE_URL, false },
 
-    { true, false, false, true, HAS_KEY, false },
+    { true, false, false, true, HAS_KEY, true },
     { true, false, false, true, HAS_ORIGIN | HAS_DEV_ORIGIN, false },
     { true, false, false, true, HAS_FALLBACK_ORIGIN, true },
     { true, false, false, true, HAS_SSL_ORIGIN, true },
     { true, false, false, true, HAS_ALT_ORIGIN, true },
     { true, false, false, true, HAS_ALT_FALLBACK_ORIGIN, true },
     { true, false, false, true, HAS_PROBE_URL, false },
 
     { false, true, true, true, HAS_NOTHING, false },
     { false, true, true, true, HAS_KEY, false },
     { false, true, true, true, HAS_ORIGIN | HAS_DEV_ORIGIN, false },
@@ skipping 96 matching lines @@
               params.IsDataReductionProxy(
                   tests[i].host_port_pair, &proxy_servers));
     EXPECT_TRUE(tests[i].expected_first.Equals(
         net::HostPortPair::FromURL(proxy_servers.first)));
     EXPECT_TRUE(tests[i].expected_second.Equals(
         net::HostPortPair::FromURL(proxy_servers.second)));
   }
 }
 
 }  // namespace data_reduction_proxy