Issue 347773003: IDL: Remove holder lookup in attribute_getter macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347773003: IDL: Remove holder lookup in attribute_getter macro (Closed)

Created:
6 years, 6 months ago by bashi

Modified:
6 years, 6 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

IDL: Remove holder lookup in attribute_getter macro According to haraken's comment on [1], we can always use info.Holder() instead of calling findInstanceInPrototypeChain(). Removing one FIXME. [1] https://codereview.chromium.org/140663012 BUG=345503 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177072

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -10 lines)			Patch
	M	Source/bindings/templates/attributes.cpp	View		1 chunk	+1 line, -7 lines	0 comments	Download
	M	Source/bindings/tests/results/V8TestObject.cpp	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bashi

Could you review this? Your comment: https://codereview.chromium.org/140663012/diff/50001/Source/bindings/templates/attributes.cpp#newcode21 As far as I tested, the return value ...

6 years, 6 months ago (2014-06-27 05:55:31 UTC) #1

haraken

LGTM. I believe findInstanceInPrototypeChain() is always equal to info.Holder in this case.

6 years, 6 months ago (2014-06-27 06:00:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/347773003/1

6 years, 6 months ago (2014-06-27 06:02:35 UTC) #4

Message was sent while issue was closed.

Change committed as 177072

Expand Messages | Collapse Messages