IDL compiler: Window-specific code + Window-only features

IDL compiler: Window-specific code + Window-only features

This is a collection of various Window-specific code (no tests)
and Window-only features (tests added):
* [CheckSecurity] + [Replaceable]
* [PutForwards] + [Replaceable]
* [PerContextEnabled] + [RuntimeEnabled]
* [DoNotCheckSecurity] + [Replaceable]
* [DoNotCheckSecurity] + [DoNotCheckSignature]

* [ImplementedAs] for constructor attributes
* header for attributes for named constructors on global objects
* [PerWorldBindings] on readonly interface types

This finishes non-SVG IDL files!!

BUG=239771
R=haraken
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166670

[haraken, 2014-02-06 07:57:44]

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/scripts/...
File Source/bindings/scripts/unstable/v8_attributes.py (right):

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/scripts/...
Source/bindings/scripts/unstable/v8_attributes.py:359: 'PutForwards' not in
extended_attributes) or

I don't fully understand this. Is this intended in general? Or is this just for
special-casing Window? (If so, we should simply use interface_name == "Window".)

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/scripts/...
Source/bindings/scripts/unstable/v8_attributes.py:379: 'Replaceable' in
extended_attributes):

Ditto.

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/scripts/...
File Source/bindings/scripts/unstable/v8_types.py (right):

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/scripts/...
Source/bindings/scripts/unstable/v8_types.py:385: if
idl_type.endswith('ConstructorConstructor'):

This looks ugly. Can we rename it to NamedConstructor?

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/template...
File Source/bindings/templates/attributes.cpp (right):

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/template...
Source/bindings/templates/attributes.cpp:21: v8::Handle<v8::Object> holder =
info.This()->FindInstanceInPrototypeChain({{v8_class}}::domTemplate(info.GetIsolate(),
worldType(info.GetIsolate())));

I don't think we need this look up. I think we can always simply use
info.Holder(). Let's try to remove the look-up in a follow-up CL.

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/template...
Source/bindings/templates/attributes.cpp:203: {{cpp_class}}* imp =
{{v8_class}}::toNative(info.Holder());

This branch is doing exactly the same thing as the '{% elif
attribute.put_forwards %}' branch.

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/template...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/template...
Source/bindings/templates/interface.cpp:31: else '0 /* on instance */' %}

I don't fully understand why we need to treat EventHandlers on Window specially,
but it's not related to your CL. (I need to consider when moving DOM attributes
to prototype chains.)

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/template...
Source/bindings/templates/interface.cpp:750: (interface_name == 'Window' and
attribute.is_unforgeable)) %}

Do we need interface_name=='Window'?

[Nils Barth (inactive), 2014-02-06 08:40:13]

Revised: FIXMEs + remove redundant branch.

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/scripts/...
File Source/bindings/scripts/unstable/v8_attributes.py (right):

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/scripts/...
Source/bindings/scripts/unstable/v8_attributes.py:359: 'PutForwards' not in
extended_attributes) or
On 2014/02/06 07:57:44, haraken wrote:
> Is this intended in general?

Yes.
I've placed 'Window' if and only if it's actually Window-specific.

Some general logic only currently occurs in Window,
but should be used generally, so I've made test cases for them.

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/scripts/...
Source/bindings/scripts/unstable/v8_attributes.py:379: 'Replaceable' in
extended_attributes):
On 2014/02/06 07:57:44, haraken wrote:
> Ditto.

Ditto: this is general.

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/scripts/...
File Source/bindings/scripts/unstable/v8_types.py (right):

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/scripts/...
Source/bindings/scripts/unstable/v8_types.py:385: if
idl_type.endswith('ConstructorConstructor'):
On 2014/02/06 07:57:44, haraken wrote:
> This looks ugly. Can we rename it to NamedConstructor?

Agreed, it's hideous - I'd be delighted to fix this!
Will do in a followup (as Perl change).

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/template...
File Source/bindings/templates/attributes.cpp (right):

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/template...
Source/bindings/templates/attributes.cpp:21: v8::Handle<v8::Object> holder =
info.This()->FindInstanceInPrototypeChain({{v8_class}}::domTemplate(info.GetIsolate(),
worldType(info.GetIsolate())));
On 2014/02/06 07:57:44, haraken wrote:
> I don't think we need this look up. I think we can always simply use
> info.Holder(). Let's try to remove the look-up in a follow-up CL.

Got it, added a FIXME.

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/template...
Source/bindings/templates/attributes.cpp:203: {{cpp_class}}* imp =
{{v8_class}}::toNative(info.Holder());
On 2014/02/06 07:57:44, haraken wrote:
> This branch is doing exactly the same thing as the '{% elif
> attribute.put_forwards %}' branch.

You mean the {% elif not attribute.is_static %} branch;
good point, removed excess branch!

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/template...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/template...
Source/bindings/templates/interface.cpp:31: else '0 /* on instance */' %}
On 2014/02/06 07:57:44, haraken wrote:
> I don't fully understand why we need to treat EventHandlers on Window
specially,
> but it's not related to your CL. (I need to consider when moving DOM
attributes
> to prototype chains.)

Got it; agreed it would be simpler to eliminate this throughout
(this is the main complexity of handling Window).

https://codereview.chromium.org/140663012/diff/50001/Source/bindings/template...
Source/bindings/templates/interface.cpp:750: (interface_name == 'Window' and
attribute.is_unforgeable)) %}
On 2014/02/06 07:57:44, haraken wrote:
> Do we need interface_name=='Window'?

Yes - this is exactly the shadowAttributes, directly above.

[Nils Barth (inactive), 2014-02-06 08:52:53]

BTW, added one more feature (one ForMainWorld suffix),
and now Window output is identical!

This means this finishes (non-SVG) IDLs!

There are probably some features used only in SVG IDLs,
but other than that, this finishes the rewrite!!

[haraken, 2014-02-06 09:09:24]

LGTM

[Nils Barth (inactive), 2014-02-06 09:32:26]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-02-06 09:32:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/140663012/180001

[commit-bot: I haz the power, 2014-02-06 09:32:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-06 09:32:54]

Failed to apply patch for Source/bindings/tests/idls/TestInterfacePython.idl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/idls/TestInterfacePython.idl
  Hunk #1 FAILED at 41.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/tests/idls/TestInterfacePython.idl.rej

Patch:       Source/bindings/tests/idls/TestInterfacePython.idl
Index: Source/bindings/tests/idls/TestInterfacePython.idl
diff --git a/Source/bindings/tests/idls/TestInterfacePython.idl
b/Source/bindings/tests/idls/TestInterfacePython.idl
index
bb2e8e2c44c01aae8ab8e4caa883b4c397a78301..94562487ac579575cef8741dbbac7bbec72584f4
100644
--- a/Source/bindings/tests/idls/TestInterfacePython.idl
+++ b/Source/bindings/tests/idls/TestInterfacePython.idl
@@ -41,6 +41,7 @@
     // configuration and method configuration, and [StrictTypeChecking]
     const unsigned long UNSIGNED_LONG = 0;
     attribute TestInterfacePython testInterfacePythonAttribute; //
Self-referential interface type with [ImplementedAs]
+    attribute TestImplementedAsConstructor
testImplementedAsConstructorAttribute;
     static attribute DOMString staticStringAttribute;
     void voidMethodTestInterfaceEmptyArg(TestInterfaceEmpty
testInterfaceEmptyArg);
     [PerWorldBindings] attribute DOMString perWorldBindingsStringAttribute;

[Nils Barth (inactive), 2014-02-07 01:18:50]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-02-07 01:19:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/140663012/280001

[commit-bot: I haz the power, 2014-02-07 01:20:02]

Change committed as 166670