Issue 347643002: Reduce forward declarations in core/dom

Issue 347643002: Reduce forward declarations in core/dom (Closed)

Created:
6 years, 6 months ago by rwlbuis

Modified:
6 years, 6 months ago

Reviewers:
davve, eseidel, Hajime Morrita, Inactive, adamk, gmorrita

CC:
blink-reviews, krit, blink-reviews-rendering, aboxhall, zoltan1, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-dom_chromium.org, dglazkov+blink, dmazzoni, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rune+blink, Stephen Chennney, ed+blinkwatch_opera.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Reduce forward declarations in core/dom BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176865

Patch Set 1 #

Patch Set 2 : Rebase against ToT #

Total comments: 3

Patch Set 3 : Remove two includes #

Patch Set 4 : Rebase against ToT #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -75 lines)			Patch
M	Source/core/accessibility/AXObject.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/Attr.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/Comment.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/ContextLifecycleNotifier.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/DOMImplementation.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/Document.h	View	1 2 3	6 chunks	+2 lines, -25 lines	0 comments	Download
M	Source/core/dom/DocumentFragment.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/DocumentMarkerController.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/DocumentParser.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/DocumentType.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/ElementDataCache.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/ExecutionContext.h	View	1 2 3	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/dom/ExecutionContextClient.h	View	1 2 3	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/dom/MessagePort.h	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/NodeRareData.h	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/dom/Position.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/ScriptLoader.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/SelectorQuery.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/dom/ShadowTreeStyleSheetCollection.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/StyleEngine.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/dom/Text.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/TextLinkColors.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/TreeScope.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/TreeScopeStyleSheetCollection.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/dom/ViewportDescription.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/custom/CustomElementRegistrationContext.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/shadow/ComposedTreeWalker.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/shadow/SelectRuleFeatureSet.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/editing/VisiblePosition.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

davve

Also, I don't think you need an empty BUG= anymore. I've been told to remove ...

6 years, 6 months ago (2014-06-19 14:40:54 UTC) #2

Inactive

https://codereview.chromium.org/347643002/diff/20001/Source/core/accessibility/AXObject.h File Source/core/accessibility/AXObject.h (right): https://codereview.chromium.org/347643002/diff/20001/Source/core/accessibility/AXObject.h#newcode33 Source/core/accessibility/AXObject.h:33: #include "core/dom/Range.h" I am all for cleaning up _unnecessary_ ...

6 years, 6 months ago (2014-06-19 15:25:17 UTC) #3

rwlbuis

On 2014/06/19 15:25:17, Chris Dumez wrote: > https://codereview.chromium.org/347643002/diff/20001/Source/core/accessibility/AXObject.h > File Source/core/accessibility/AXObject.h (right): > > https://codereview.chromium.org/347643002/diff/20001/Source/core/accessibility/AXObject.h#newcode33 ...

6 years, 6 months ago (2014-06-19 15:32:50 UTC) #4

rwlbuis

On 2014/06/19 14:40:54, David Vest wrote: > Also, I don't think you need an empty ...

6 years, 6 months ago (2014-06-19 15:34:08 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/347643002/60001

6 years, 6 months ago (2014-06-24 16:49:51 UTC) #10

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 6 months ago (2014-06-24 18:04:22 UTC) #11

Message was sent while issue was closed.

Change committed as 176865

Expand Messages | Collapse Messages