Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1546)

Unified Diff: chrome/browser/password_manager/password_store_x.cc

Issue 347583004: PasswordStore refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_x.cc
diff --git a/chrome/browser/password_manager/password_store_x.cc b/chrome/browser/password_manager/password_store_x.cc
index 2fbe63c8a03f8916aae9f349cafe54f9d149c0b1..caa1dd628ec0ac40a99fd66fe6b7046d605d15eb 100644
--- a/chrome/browser/password_manager/password_store_x.cc
+++ b/chrome/browser/password_manager/password_store_x.cc
@@ -87,26 +87,19 @@ PasswordStoreChangeList PasswordStoreX::RemoveLoginImpl(
}
PasswordStoreChangeList PasswordStoreX::RemoveLoginsCreatedBetweenImpl(
- const base::Time& delete_begin,
- const base::Time& delete_end) {
+ base::Time delete_begin,
+ base::Time delete_end) {
CheckMigration();
- vector<PasswordForm*> forms;
PasswordStoreChangeList changes;
if (use_native_backend() &&
- backend_->GetLoginsCreatedBetween(delete_begin, delete_end, &forms) &&
- backend_->RemoveLoginsCreatedBetween(delete_begin, delete_end)) {
- for (vector<PasswordForm*>::const_iterator it = forms.begin();
- it != forms.end(); ++it) {
- changes.push_back(PasswordStoreChange(PasswordStoreChange::REMOVE,
- **it));
- }
+ backend_->RemoveLoginsCreatedBetween(
+ delete_begin, delete_end, &changes)) {
LogStatsForBulkDeletion(changes.size());
allow_fallback_ = false;
} else if (allow_default_store()) {
changes = PasswordStoreDefault::RemoveLoginsCreatedBetweenImpl(delete_begin,
delete_end);
}
- STLDeleteElements(&forms);
return changes;
}
« no previous file with comments | « chrome/browser/password_manager/password_store_x.h ('k') | chrome/browser/password_manager/password_store_x_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698