PasswordStore refactoring.

chrome/browser/password_manager/password_store_x.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_store_x.h"
 
 #include <algorithm>
 #include <map>
 #include <vector>
 
@@ skipping 69 matching lines @@
   if (use_native_backend() && backend_->RemoveLogin(form)) {
     changes.push_back(PasswordStoreChange(PasswordStoreChange::REMOVE, form));
     allow_fallback_ = false;
   } else if (allow_default_store()) {
     changes = PasswordStoreDefault::RemoveLoginImpl(form);
   }
   return changes;
 }
 
 PasswordStoreChangeList PasswordStoreX::RemoveLoginsCreatedBetweenImpl(
-    const base::Time& delete_begin,
-    const base::Time& delete_end) {
+    base::Time delete_begin,
+    base::Time delete_end) {
   CheckMigration();
-  vector<PasswordForm*> forms;
   PasswordStoreChangeList changes;
   if (use_native_backend() &&
-      backend_->GetLoginsCreatedBetween(delete_begin, delete_end, &forms) &&
-      backend_->RemoveLoginsCreatedBetween(delete_begin, delete_end)) {
-    for (vector<PasswordForm*>::const_iterator it = forms.begin();
-         it != forms.end(); ++it) {
-      changes.push_back(PasswordStoreChange(PasswordStoreChange::REMOVE,
-                                            **it));
-    }
+      backend_->RemoveLoginsCreatedBetween(
+          delete_begin, delete_end, &changes)) {
     LogStatsForBulkDeletion(changes.size());
     allow_fallback_ = false;
   } else if (allow_default_store()) {
     changes = PasswordStoreDefault::RemoveLoginsCreatedBetweenImpl(delete_begin,
                                                                    delete_end);
   }
-  STLDeleteElements(&forms);
   return changes;
 }
 
 PasswordStoreChangeList PasswordStoreX::RemoveLoginsSyncedBetweenImpl(
     base::Time delete_begin,
     base::Time delete_end) {
   CheckMigration();
   PasswordStoreChangeList changes;
   if (use_native_backend() &&
       backend_->RemoveLoginsSyncedBetween(delete_begin, delete_end, &changes)) {
@@ skipping 162 matching lines @@
       // it before deleting the file just in case there is some problem deleting
       // the file (e.g. directory is not writable, but file is), which would
       // otherwise cause passwords to re-migrate next (or maybe every) time.
       DeleteAndRecreateDatabaseFile();
     }
   }
   ssize_t result = ok ? forms.size() : -1;
   STLDeleteElements(&forms);
   return result;
 }