Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1736)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 347583004: PasswordStore refactoring. (Closed)

Created:
6 years, 6 months ago by vasilii
Modified:
6 years, 6 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org, vabr (Chromium), Nicolas Zea
Project:
chromium
Visibility:
Public.

Description

PasswordStore refactoring. This is a cleanup CL after https://codereview.chromium.org/335893002. Some method's signatures have changed, new unit tests for PasswordStoreX were added. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -251 lines) Patch
M chrome/browser/password_manager/native_backend_gnome_x.h View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x_unittest.cc View 3 chunks +86 lines, -58 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x.h View 2 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x.cc View 3 chunks +5 lines, -41 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc View 3 chunks +89 lines, -64 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_x.h View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/password_manager/password_store_x.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 4 chunks +8 lines, -20 lines 0 comments Download
M components/password_manager/core/browser/login_database.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/login_database.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/mock_password_store.h View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_store.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/password_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/password_store_default.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_store_default.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/password_manager/core/browser/test_password_store.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/password_manager/core/browser/test_password_store.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
vasilii
Hi Garrett, please review the CL addressing your comments.
6 years, 6 months ago (2014-06-18 14:59:59 UTC) #1
Garrett Casto
lgtm
6 years, 6 months ago (2014-06-18 22:21:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/347583004/1
6 years, 6 months ago (2014-06-18 22:24:45 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 02:00:08 UTC) #4
Message was sent while issue was closed. 
Change committed as 278242

Powered by Google App Engine
This is Rietveld 408576698