Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 347583003: DevTools: add emulation toggle button and splash screen. (Closed)

Created:
6 years, 6 months ago by pfeldman
Modified:
6 years, 6 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: add emulation toggle button and splash screen. BUG=327641 R=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176425

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebaselined #

Patch Set 3 : For landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -113 lines) Patch
M Source/devtools/front_end/ResponsiveDesignView.js View 8 chunks +24 lines, -39 lines 0 comments Download
M Source/devtools/front_end/elements/OverridesView.js View 8 chunks +58 lines, -6 lines 0 comments Download
M Source/devtools/front_end/elements/module.json View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/inspector.css View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/devtools/front_end/overrides.css View 1 2 3 chunks +23 lines, -1 line 0 comments Download
M Source/devtools/front_end/responsiveDesignView.css View 1 2 11 chunks +40 lines, -61 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pfeldman
6 years, 6 months ago (2014-06-18 14:31:48 UTC) #1
dgozman
lgtm https://codereview.chromium.org/347583003/diff/1/Source/devtools/front_end/responsiveDesignView.css File Source/devtools/front_end/responsiveDesignView.css (right): https://codereview.chromium.org/347583003/diff/1/Source/devtools/front_end/responsiveDesignView.css#newcode157 Source/devtools/front_end/responsiveDesignView.css:157: + Remove this plus sign.
6 years, 6 months ago (2014-06-18 14:43:01 UTC) #2
pfeldman
https://codereview.chromium.org/347583003/diff/1/Source/devtools/front_end/responsiveDesignView.css File Source/devtools/front_end/responsiveDesignView.css (right): https://codereview.chromium.org/347583003/diff/1/Source/devtools/front_end/responsiveDesignView.css#newcode157 Source/devtools/front_end/responsiveDesignView.css:157: + On 2014/06/18 14:43:01, dgozman wrote: > Remove this ...
6 years, 6 months ago (2014-06-18 14:57:21 UTC) #3
pfeldman
6 years, 6 months ago (2014-06-18 15:04:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r176425 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698