Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4400)

Unified Diff: Source/devtools/front_end/sdk/OverridesSupport.js

Issue 347583003: DevTools: add emulation toggle button and splash screen. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/responsiveDesignView.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/OverridesSupport.js
diff --git a/Source/devtools/front_end/sdk/OverridesSupport.js b/Source/devtools/front_end/sdk/OverridesSupport.js
index 26d56cabf001c3b0811e1bac8910ae5e1c0687e4..af745677827a6a7728709a4aadab1fedb47c7cf4 100644
--- a/Source/devtools/front_end/sdk/OverridesSupport.js
+++ b/Source/devtools/front_end/sdk/OverridesSupport.js
@@ -265,7 +265,7 @@ WebInspector.OverridesSupport.deviceSizeValidator = function(value)
*/
WebInspector.OverridesSupport.deviceScaleFactorValidator = function(value)
{
- if (!value || (/^[\d]+(\.\d+)?|\.\d+$/.test(value) && value >= 0 && value <= 10000))
+ if (!value || (/^[\d]+(\.\d+)?|\.\d+$/.test(value) && value >= 0 && value <= 10))
return "";
return WebInspector.UIString("Value must be non-negative float");
}
@@ -994,7 +994,7 @@ WebInspector.OverridesSupport.prototype = {
var devices = WebInspector.OverridesSupport._phones.concat(WebInspector.OverridesSupport._tablets).concat(WebInspector.OverridesSupport._desktops);
devices.sort();
- var selectDevice = [WebInspector.UIString("<Select device>"), "", ""];
+ var selectDevice = [WebInspector.UIString("<Select model>"), "", ""];
devices = devices.concat([selectDevice]);
for (var i = 0; i < devices.length; ++i) {
var device = devices[i];
@@ -1088,6 +1088,11 @@ WebInspector.OverridesSupport.prototype = {
return throughputSelectElement;
},
+ reveal: function()
+ {
+ WebInspector.Revealer.reveal(this);
+ },
+
__proto__: WebInspector.Object.prototype
}
« no previous file with comments | « Source/devtools/front_end/responsiveDesignView.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698