Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 347553002: Use WebLockOrientationError instead of WebLockOrientationCallbackErrorType. (Closed)

Created:
6 years, 6 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup_web_screen_orientation_listener
Project:
chromium
Visibility:
Public.

Description

Use WebLockOrientationError instead of WebLockOrientationCallbackErrorType. This is the Chromium side of https://codereview.chromium.org/332493003/ BUG=162827 TBR=jam@chromium.org (for content/common/DEPS) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -29 lines) Patch
M content/browser/screen_orientation/screen_orientation_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/common/screen_orientation_messages.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/screen_orientation/screen_orientation_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/screen_orientation/screen_orientation_dispatcher.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/screen_orientation/screen_orientation_dispatcher_unittest.cc View 6 chunks +11 lines, -17 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
mlamouri (slow - plz ping)
dcheng@, could you review the changes in: * content/common/screen_orientation_messages.h * content/*/screen_orientation/* jochen@, could you review ...
6 years, 6 months ago (2014-06-18 13:12:56 UTC) #1
dcheng
On 2014/06/18 at 13:12:56, mlamouri wrote: > dcheng@, could you review the changes in: > ...
6 years, 6 months ago (2014-06-18 16:47:15 UTC) #2
mlamouri (slow - plz ping)
Adam, any chance you can have a look at the DEPS file change? I believe ...
6 years, 6 months ago (2014-06-19 19:30:04 UTC) #3
abarth-chromium
LGTM
6 years, 6 months ago (2014-06-19 20:54:26 UTC) #4
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-06-21 16:03:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/347553002/1
6 years, 6 months ago (2014-06-21 16:05:26 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-21 20:14:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-21 20:16:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/75556)
6 years, 6 months ago (2014-06-21 20:16:41 UTC) #9
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-06-23 09:25:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/347553002/1
6 years, 6 months ago (2014-06-23 09:26:31 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-23 09:29:36 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 09:32:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/75631)
6 years, 6 months ago (2014-06-23 09:32:00 UTC) #14
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-06-23 09:35:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/347553002/1
6 years, 6 months ago (2014-06-23 09:36:35 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 09:53:21 UTC) #17
Message was sent while issue was closed.
Change committed as 279073

Powered by Google App Engine
This is Rietveld 408576698