content/renderer/screen_orientation/screen_orientation_dispatcher.cc - Issue 347553002: Use WebLockOrientationError instead of WebLockOrientationCallbackErrorType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/screen_orientation/screen_orientation_dispatcher.cc

Issue 347553002: Use WebLockOrientationError instead of WebLockOrientationCallbackErrorType. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_web_screen_orientation_listener

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/screen_orientation/screen_orientation_dispatcher.h ('k') | content/renderer/screen_orientation/screen_orientation_dispatcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/screen_orientation/screen_orientation_dispatcher.cc

diff --git a/content/renderer/screen_orientation/screen_orientation_dispatcher.cc b/content/renderer/screen_orientation/screen_orientation_dispatcher.cc

index e67cc73634ec79a3541815223011e5f6d3f4f661..7e5bcfcd382aa85cf0c6add2a6d6517c39dd9dae 100644

--- a/content/renderer/screen_orientation/screen_orientation_dispatcher.cc

+++ b/content/renderer/screen_orientation/screen_orientation_dispatcher.cc

@@ -44,8 +44,7 @@ void ScreenOrientationDispatcher::OnLockSuccess(

}

void ScreenOrientationDispatcher::OnLockError(

- int request_id,

- blink::WebLockOrientationCallback::ErrorType error) {

+ int request_id, blink::WebLockOrientationError error) {

blink::WebLockOrientationCallback* callback =

pending_callbacks_.Lookup(request_id);

if (!callback)

@@ -57,8 +56,7 @@ void ScreenOrientationDispatcher::OnLockError(

void ScreenOrientationDispatcher::CancelPendingLocks() {

for (CallbackMap::Iterator<blink::WebLockOrientationCallback>

iterator(&pending_callbacks_); !iterator.IsAtEnd(); iterator.Advance()) {

- iterator.GetCurrentValue()->onError(

- blink::WebLockOrientationCallback::ErrorTypeCanceled);

+ iterator.GetCurrentValue()->onError(blink::WebLockOrientationErrorCanceled);

pending_callbacks_.Remove(iterator.GetCurrentKey());

}