Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: content/browser/renderer_host/websocket_host.cc

Issue 34753008: Notify WebSocket connection failure, chromium side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address a blink-side review comment Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/websocket_host.cc
diff --git a/content/browser/renderer_host/websocket_host.cc b/content/browser/renderer_host/websocket_host.cc
index 4b5faec37e9f1a6475ee3c59054c29905f3b8998..4d1b4a46d8249b5b903d74de04da2e1db253527e 100644
--- a/content/browser/renderer_host/websocket_host.cc
+++ b/content/browser/renderer_host/websocket_host.cc
@@ -193,11 +193,14 @@ void WebSocketHost::OnFlowControl(int64 quota) {
channel_->SendFlowControl(quota);
}
-void WebSocketHost::OnDropChannel(uint16 code, const std::string& reason) {
+void WebSocketHost::OnDropChannel(bool was_clean,
+ uint16 code,
+ const std::string& reason) {
DVLOG(3) << "WebSocketDispatcherHost::OnDropChannel"
- << " routing_id= " << routing_id_ << " code= " << code
- << " reason= " << reason;
+ << " routing_id= " << routing_id_ << " was_clean = " << was_clean
+ << " code= " << code << " reason= " << reason;
+ // TODO(yhirano): Handle |was_clean| appropriately.
channel_->StartClosingHandshake(code, reason);
}

Powered by Google App Engine
This is Rietveld 408576698