Notify WebSocket connection failure, chromium side

content/common/websocket_messages.h

Index: content/common/websocket_messages.h
diff --git a/content/common/websocket_messages.h b/content/common/websocket_messages.h
index 5a9304f8a700888fcfc2b5c7b72fdf566ac5341e..e0f1885716c104e8ec340787b8de5386bfc07b16 100644
--- a/content/common/websocket_messages.h
+++ b/content/common/websocket_messages.h
@@ -43,7 +43,7 @@ IPC_MESSAGE_ROUTED3(WebSocketHostMsg_AddChannelRequest,
                     std::vector<std::string> /* requested_protocols */,
                     GURL /* origin */)
 
-// Web Socket messages sent from the browser to the renderer.
+// WebSocket messages sent from the browser to the renderer.
 
 // Respond to an AddChannelRequest for channel |channel_id|. |channel_id| is
 // scoped to the renderer process; while it is unique per-renderer, the browser
@@ -59,6 +59,17 @@ IPC_MESSAGE_ROUTED3(WebSocketMsg_AddChannelResponse,
                     std::string /* selected_protocol */,
                     std::string /* extensions */)
 
+// Notify the renderer that the browser is required to fail the connection.

[Tom Sepez, 2013/10/31 19:07:53]

nit: is required by whom? or why is it required?

[yhirano, 2013/11/01 05:58:35]

By the spec. RFC6455 says:

Certain algorithms and specifications require an endpoint to _Failthe WebSocket
Connection_.

I added a link to the spec.

+// When the renderer process is received this message, it will drop the

[Tom Sepez, 2013/10/31 19:07:53]

nit: When the renderer process receives this message,

[yhirano, 2013/11/01 05:58:35]

Thanks, done.

+// channel as if it were received
+// DropChannel(was_clean = false, code = 1006, reason = "").
+// |message| will be shown in the inspector and won't be passed to the

[Tom Sepez, 2013/10/31 19:07:53]

nit: why not just send the WebSocket_DropChannel then?

[yhirano, 2013/11/01 05:58:35]

The renderer process need to distinguish failure to fire an error event.

+// script.
+// TODO(yhirano): Find the way to pass |message| directly to the inspector
+// process.
+IPC_MESSAGE_ROUTED1(WebSocketMsg_NotifyFailure,
+                    std::string /* message */)
+
 // WebSocket messages that can be sent in either direction.
 
 IPC_ENUM_TRAITS(content::WebSocketMessageType)
@@ -100,6 +111,12 @@ IPC_MESSAGE_ROUTED1(WebSocketMsg_FlowControl,
 // UTF-8 encoded string which may be useful for debugging but is not necessarily
 // human-readable, as supplied by the server in the Close or DropChannel
 // message.
-IPC_MESSAGE_ROUTED2(WebSocketMsg_DropChannel,
+// If |was_clean| is false on a message from the browser, then the WebSocket
+// connection was not closed cleanly. If |was_clean| is false on a message from
+// the renderer, then the connection should be closed immediately without a
+// closing handshake and the renderer cannot accept any new messages about this

[Tom Sepez, 2013/10/31 19:07:53]

nit: on this connection.

[yhirano, 2013/11/01 05:58:35]

Done.

+// connection.
+IPC_MESSAGE_ROUTED3(WebSocketMsg_DropChannel,
+                    bool /* was_clean */,
                     unsigned short /* code */,
                     std::string /* reason */)