Issue 34753002: make input type=color RTL direction aware

Issue 34753002: make input type=color RTL direction aware (Closed)

Created:
7 years, 2 months ago by pals

Modified:
7 years, 1 month ago

Reviewers:
tkent, leviw_travelin_and_unemployed, eseidel, ojan

CC:
blink-reviews, zoltan1, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

make input type=color RTL direction aware BUG=232333 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160714

Patch Set 2 : Fixed review comments and added test #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/forms/color/input-appearance-color.html	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	LayoutTests/platform/linux/fast/forms/color/input-appearance-color-expected.png	View	1	Binary file		0 comments	Download
M	LayoutTests/platform/win/fast/forms/color/input-appearance-color-expected.txt	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderTheme.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

eseidel

Seems reasonable to me, but I don't feel particularly form-informed. :)

7 years, 1 month ago (2013-10-26 18:04:58 UTC) #4

tkent

This change needs a test. I recommend to add a test case to LayoutTests/fast/forms/color/input-appearance-color.html. https://codereview.chromium.org/34753002/diff/1/Source/core/rendering/RenderTheme.cpp ...

7 years, 1 month ago (2013-10-27 21:53:48 UTC) #5

pals

Added test. Please review. https://codereview.chromium.org/34753002/diff/1/Source/core/rendering/RenderTheme.cpp File Source/core/rendering/RenderTheme.cpp (right): https://codereview.chromium.org/34753002/diff/1/Source/core/rendering/RenderTheme.cpp#newcode494 Source/core/rendering/RenderTheme.cpp:494: runtimeCSS.appendLiteral("input[type=\"color\"][list]::-webkit-color-swatch-wrapper-rtl { padding-left: 24px; padding-right: ...

7 years, 1 month ago (2013-10-28 08:45:51 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/34753002/90001

7 years, 1 month ago (2013-10-28 10:20:08 UTC) #8

tkent

7 years, 1 month ago (2013-10-28 22:30:46 UTC) #10

Message was sent while issue was closed.

On 2013/10/28 11:22:51, I haz the power (commit-bot) wrote:
> Change committed as 160714

OSX result looks wrong. I'll revert r160714.
https://codereview.chromium.org/48693002/diff/1/LayoutTests/platform/mac/fast...

Expand Messages | Collapse Messages