Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Source/core/rendering/RenderTheme.cpp

Issue 34753002: make input type=color RTL direction aware (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/forms/ColorInputType.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * This file is part of the theme implementation for form controls in WebCore. 2 * This file is part of the theme implementation for form controls in WebCore.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc. 4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 473 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 if (!RuntimeEnabledFeatures::dataListElementEnabled() && !RuntimeEnabledFeat ures::dialogElementEnabled()) 484 if (!RuntimeEnabledFeatures::dataListElementEnabled() && !RuntimeEnabledFeat ures::dialogElementEnabled())
485 return String(); 485 return String();
486 StringBuilder runtimeCSS; 486 StringBuilder runtimeCSS;
487 487
488 if (RuntimeEnabledFeatures::dataListElementEnabled()) { 488 if (RuntimeEnabledFeatures::dataListElementEnabled()) {
489 runtimeCSS.appendLiteral("datalist {display: none ;}"); 489 runtimeCSS.appendLiteral("datalist {display: none ;}");
490 490
491 if (RuntimeEnabledFeatures::inputTypeColorEnabled()) { 491 if (RuntimeEnabledFeatures::inputTypeColorEnabled()) {
492 runtimeCSS.appendLiteral("input[type=\"color\"][list] { -webkit-appe arance: menulist; width: 88px; height: 23px;}"); 492 runtimeCSS.appendLiteral("input[type=\"color\"][list] { -webkit-appe arance: menulist; width: 88px; height: 23px;}");
493 runtimeCSS.appendLiteral("input[type=\"color\"][list]::-webkit-color -swatch-wrapper { padding-left: 8px; padding-right: 24px;}"); 493 runtimeCSS.appendLiteral("input[type=\"color\"][list]::-webkit-color -swatch-wrapper { padding-left: 8px; padding-right: 24px;}");
494 runtimeCSS.appendLiteral("input[type=\"color\"][list]::-webkit-color -swatch-wrapper-rtl { padding-left: 24px; padding-right: 8px;}");
tkent 2013/10/27 21:53:48 padding-left/right in the previous line should be
pals 2013/10/28 08:45:51 Done. Good idea. Thanks
494 runtimeCSS.appendLiteral("input[type=\"color\"][list]::-webkit-color -swatch { border-color: #000000;}"); 495 runtimeCSS.appendLiteral("input[type=\"color\"][list]::-webkit-color -swatch { border-color: #000000;}");
495 } 496 }
496 } 497 }
497 if (RuntimeEnabledFeatures::dialogElementEnabled()) { 498 if (RuntimeEnabledFeatures::dialogElementEnabled()) {
498 runtimeCSS.appendLiteral("dialog:not([open]) { display: none; }"); 499 runtimeCSS.appendLiteral("dialog:not([open]) { display: none; }");
499 runtimeCSS.appendLiteral("dialog { position: absolute; left: 0; right: 0 ; width: -webkit-fit-content; height: -webkit-fit-content; margin: auto; border: solid; padding: 1em; background: white; color: black;}"); 500 runtimeCSS.appendLiteral("dialog { position: absolute; left: 0; right: 0 ; width: -webkit-fit-content; height: -webkit-fit-content; margin: auto; border: solid; padding: 1em; background: white; color: black;}");
500 runtimeCSS.appendLiteral("dialog::backdrop { position: fixed; top: 0; ri ght: 0; bottom: 0; left: 0; background: rgba(0,0,0,0.1); }"); 501 runtimeCSS.appendLiteral("dialog::backdrop { position: fixed; top: 0; ri ght: 0; bottom: 0; left: 0; background: rgba(0,0,0,0.1); }");
501 } 502 }
502 503
503 return runtimeCSS.toString(); 504 return runtimeCSS.toString();
(...skipping 869 matching lines...) Expand 10 before | Expand all | Expand 10 after
1373 1374
1374 // padding - not honored by WinIE, needs to be removed. 1375 // padding - not honored by WinIE, needs to be removed.
1375 style->resetPadding(); 1376 style->resetPadding();
1376 1377
1377 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme) 1378 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme)
1378 // for now, we will not honor it. 1379 // for now, we will not honor it.
1379 style->resetBorder(); 1380 style->resetBorder();
1380 } 1381 }
1381 1382
1382 } // namespace WebCore 1383 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/forms/ColorInputType.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698