OMX component state transition from Loaded to Idle may not be completed...

OMX component state transition from Loaded to Idle may not be completed
because during input port configuration port_format.nBufferCountMin is
used which may differ from component's port_format.nBufferCountActual
value. In this case component will expect port_format.nBufferCountActual
of input buffers to be allocated before it can enter Idle state.
Aligned to VideoRendererBase::ConsumeVideoFrame which expects number of
frames to be not more than Limits::kMaxVideoFrames.
BUG=none
TEST=use an OMX component which has port_format.nBufferCountMin not equal
to port_format.nBufferCountActual.

[Oleksandr Andrushchenko, 2010-09-20 19:31:24]

please review the change
thanks

[Oleksandr Andrushchenko, 2010-09-21 05:00:48]

I have updated the patch in order to support port_format.nBufferCountActual
buffers, but not more than Limits::kMaxVideoFrames

[Alpha Left Google, 2010-09-22 17:27:26]

I don't think you need to cap port_format.nBufferCountActual at kMaxVideoFrames,
that constant is only for the maximum number of frames that we keep for
rendering, but you are using this to cap input_buffer_count_.

You can just simply assign input_buffer_count_ with
port_format.nBufferCountActual.

[Alpha Left Google, 2010-09-22 17:27:35]

LGTM after that is done.

[Oleksandr Andrushchenko, 2010-09-22 17:50:53]

On 2010/09/22 17:27:35, Alpha wrote:
> LGTM after that is done.

Is this what you mean? :)

[Alpha Left Google, 2010-09-22 18:13:47]

yup. LGTM.