Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 3475001: OMX component state transition from Loaded to Idle may not be completed... (Closed)

Created:
9 years, 2 months ago by Oleksandr Andrushchenko
Modified:
7 years, 9 months ago
Visibility:
Public.

Description

OMX component state transition from Loaded to Idle may not be completed because during input port configuration port_format.nBufferCountMin is used which may differ from component's port_format.nBufferCountActual value. In this case component will expect port_format.nBufferCountActual of input buffers to be allocated before it can enter Idle state. Aligned to VideoRendererBase::ConsumeVideoFrame which expects number of frames to be not more than Limits::kMaxVideoFrames. BUG=none TEST=use an OMX component which has port_format.nBufferCountMin not equal to port_format.nBufferCountActual.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/video/omx_video_decode_engine.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Oleksandr Andrushchenko
please review the change thanks
9 years, 2 months ago (2010-09-20 19:31:24 UTC) #1
Oleksandr Andrushchenko
9 years, 2 months ago (2010-09-20 19:33:07 UTC) #2
Oleksandr Andrushchenko
I have updated the patch in order to support port_format.nBufferCountActual buffers, but not more than ...
9 years, 2 months ago (2010-09-21 05:00:48 UTC) #3
Alpha Left Google
I don't think you need to cap port_format.nBufferCountActual at kMaxVideoFrames, that constant is only for ...
9 years, 2 months ago (2010-09-22 17:27:26 UTC) #4
Alpha Left Google
LGTM after that is done.
9 years, 2 months ago (2010-09-22 17:27:35 UTC) #5
Oleksandr Andrushchenko
On 2010/09/22 17:27:35, Alpha wrote: > LGTM after that is done. Is this what you ...
9 years, 2 months ago (2010-09-22 17:50:53 UTC) #6
Alpha Left Google
9 years, 2 months ago (2010-09-22 18:13:47 UTC) #7
yup. LGTM.

Powered by Google App Engine
This is Rietveld 408576698