Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 347473002: Fix a few header order violations (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, c.shu
Project:
blink
Visibility:
Public.

Description

Fix a few header order violations 2 real violations were masked by skipping check-webkit-style in this CL: Manually commit changes that cause false-alarm on check-webkit-style. https://codereview.chromium.org/330323005/ This fixes them. BUG=381876 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176384

Patch Set 1 #

Patch Set 2 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/html/parser/HTMLConstructionSite.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLTProcessorLibxslt.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
More fixes.
6 years, 6 months ago (2014-06-18 02:01:00 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-18 02:01:36 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-18 02:04:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/347473002/20001
6 years, 6 months ago (2014-06-18 02:05:10 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 03:25:49 UTC) #5
Message was sent while issue was closed.
Change committed as 176384

Powered by Google App Engine
This is Rietveld 408576698