Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 347393002: Rebaseline shadertext2 after SkPaint::measureText changes (Closed)

Created:
6 years, 6 months ago by Kimmo Kinnunen
Modified:
6 years, 6 months ago
Reviewers:
jvanverth1, mtklein, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rebaseline shadertext2 after SkPaint::measureText changes Rebaseline shadertext2 after commit "Fix SkPaint::measureText for stroked hairline text". Unignore ignored shadertext2 for Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug pdf-poppler. The label "Filled" in the test moves to the left due to the changes in the measurement. The SkPaint::measureText will use the "use paths" code path, similar to the drawing code. This results in different length for the string "Filled". As a side-note, the test probably measures either wrong text or uses wrong paint. This can be fixed separately. NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/0156c7646c83ee9932f016ff208cf339fec82446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -47 lines) Patch
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug/expected-results.json View 1 chunk +1 line, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Kimmo Kinnunen
This should fix the bots
6 years, 6 months ago (2014-06-23 08:11:07 UTC) #1
Kimmo Kinnunen
The CQ bit was checked by kkinnunen@nvidia.com
6 years, 6 months ago (2014-06-23 08:11:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/347393002/1
6 years, 6 months ago (2014-06-23 08:11:41 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 08:11:41 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 6 months ago (2014-06-23 08:11:41 UTC) #5
jvanverth1
lgtm
6 years, 6 months ago (2014-06-23 13:40:01 UTC) #6
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 6 months ago (2014-06-23 13:58:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/347393002/1
6 years, 6 months ago (2014-06-23 13:59:04 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 13:59:10 UTC) #9
commit-bot: I haz the power
Failed to apply patch for expectations/gm/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug/expected-results.json: While running git apply --index -p1; error: patch failed: ...
6 years, 6 months ago (2014-06-23 13:59:10 UTC) #10
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 6 months ago (2014-06-23 13:59:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/347393002/1
6 years, 6 months ago (2014-06-23 13:59:33 UTC) #12
commit-bot: I haz the power
Change committed as 0156c7646c83ee9932f016ff208cf339fec82446
6 years, 6 months ago (2014-06-23 13:59:51 UTC) #13
rmistry
6 years, 6 months ago (2014-06-23 15:25:01 UTC) #14
Message was sent while issue was closed.
On 2014/06/23 13:59:51, I haz the power (commit-bot) wrote:
> Change committed as 0156c7646c83ee9932f016ff208cf339fec82446

Looks like this CL left out Test-Win7-ShuttleA-HD2000-x86-Release
shadertext2_gpu and shadertext2_8888.

Powered by Google App Engine
This is Rietveld 408576698