Issue 347293003: Added support for string-enum-list.

Issue 347293003: Added support for string-enum-list. (Closed)

Created:
6 years, 6 months ago by Joao da Silva

Modified:
6 years, 6 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
grit-developer_googlegroups.com

Base URL:
http://grit-i18n.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Added support for string-enum-list. Added string-enum-list as a valid policy type. This acts just like 'list' in terms of the policy templates generated, but the documentation generated is different (it allows enumerating the valid values). Landing on behalf of atwilson@chromium.org, reviewed at https://codereview.chromium.org/352163003. Committed: https://code.google.com/p/grit-i18n/source/detail?r=170

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+521 lines, -11 lines)			Patch
M	grit/format/policy_templates/policy_template_generator.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	grit/format/policy_templates/policy_template_generator_unittest.py	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/adm_writer.py	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	grit/format/policy_templates/writers/adm_writer_unittest.py	View	1 chunk	+80 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/adml_writer.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	grit/format/policy_templates/writers/adml_writer_unittest.py	View	1 chunk	+38 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/admx_writer.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	grit/format/policy_templates/writers/admx_writer_unittest.py	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/doc_writer.py	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	grit/format/policy_templates/writers/doc_writer_unittest.py	View	2 chunks	+35 lines, -1 line	0 comments	Download
M	grit/format/policy_templates/writers/ios_plist_writer_unittest.py	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/json_writer_unittest.py	View	1 chunk	+33 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/plist_strings_writer.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	grit/format/policy_templates/writers/plist_strings_writer_unittest.py	View	1 chunk	+105 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/plist_writer.py	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	grit/format/policy_templates/writers/plist_writer_unittest.py	View	1 chunk	+121 lines, -0 lines	0 comments	Download
M	grit/format/policy_templates/writers/reg_writer.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	grit/format/policy_templates/writers/reg_writer_unittest.py	View	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Committed patchset #1 manually as r170 (presubmit successful).

6 years, 6 months ago (2014-06-26 11:37:50 UTC) #1

Joao da Silva

6 years, 6 months ago (2014-06-26 11:38:28 UTC) #2

Message was sent while issue was closed.

FYI. Original CL at https://codereview.chromium.org/352163003.

Expand Messages | Collapse Messages