Added support for string-enum-list.

Added support for string-enum-list.

Added string-enum-list as a valid policy type. This acts just like 'list' in
terms of the policy templates generated, but the documentation generated is
different (it allows enumerating the valid values).

BUG=none

[Andrew T Wilson (Slow), 2014-06-25 16:08:00]

PTAL

[Joao da Silva, 2014-06-25 16:46:57]

lgtm

See the suggestion inline for the plist_writer. It's not a blocker but would
make the WorkgroupManager restrict input to the right range.

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
File grit/format/policy_templates/writers/adm_writer_unittest.py (right):

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/adm_writer_unittest.py:556: # Tests a
policy group with a single policy of type 'list'.
string-enum-list

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
File grit/format/policy_templates/writers/plist_strings_writer_unittest.py
(right):

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/plist_strings_writer_unittest.py:130: 
single newline

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/plist_strings_writer_unittest.py:178: #
Tests a policy group with a single policy of type 'list'.
string-enum-list

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
File grit/format/policy_templates/writers/plist_writer_unittest.py (right):

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/plist_writer_unittest.py:227: # Tests a
policy group with a single policy of type 'list'.
string-enum-list

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/plist_writer_unittest.py:282:
<string>string</string>
See the int-enum example below: it's possible to enumerate the valid values
here. It'd be cool to do the same for string-enum-list.

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
File grit/format/policy_templates/writers/reg_writer_unittest.py (right):

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/reg_writer_unittest.py:216: # Tests a
policy group with a single policy of type 'list'.
string-enum-list

[Andrew T Wilson (Slow), 2014-06-26 08:08:57]

PTAL, and if it still looks good, please land for me.

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
File grit/format/policy_templates/writers/adm_writer_unittest.py (right):

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/adm_writer_unittest.py:556: # Tests a
policy group with a single policy of type 'list'.
On 2014/06/25 16:46:56, Joao da Silva wrote:
> string-enum-list

Done.

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
File grit/format/policy_templates/writers/plist_strings_writer_unittest.py
(right):

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/plist_strings_writer_unittest.py:130: 
On 2014/06/25 16:46:56, Joao da Silva wrote:
> single newline

Done.

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/plist_strings_writer_unittest.py:178: #
Tests a policy group with a single policy of type 'list'.
On 2014/06/25 16:46:56, Joao da Silva wrote:
> string-enum-list

Done.

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
File grit/format/policy_templates/writers/plist_writer_unittest.py (right):

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/plist_writer_unittest.py:227: # Tests a
policy group with a single policy of type 'list'.
On 2014/06/25 16:46:56, Joao da Silva wrote:
> string-enum-list

Done.

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/plist_writer_unittest.py:282:
<string>string</string>
On 2014/06/25 16:46:57, Joao da Silva wrote:
> See the int-enum example below: it's possible to enumerate the valid values
> here. It'd be cool to do the same for string-enum-list.

I'm trying really hard not to have to actually test that the output works on all
different platforms - that's why I'm trying to make the string-enum-list output
look exactly like list output. If I make the change you describe, I'd have to go
off and make sure that the resulting template works, and I don't want to do that
for this change - the motivation for this change is primarily to enable more
readable documentation.

If you're setup to test the output template on my behalf, I'm happy to drive a
followup CL with this change that you can test.

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
File grit/format/policy_templates/writers/reg_writer_unittest.py (right):

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/reg_writer_unittest.py:216: # Tests a
policy group with a single policy of type 'list'.
On 2014/06/25 16:46:57, Joao da Silva wrote:
> string-enum-list

Done.

[Joao da Silva, 2014-06-26 11:34:07]

lgtm, I'll get this landed.

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
File grit/format/policy_templates/writers/plist_writer_unittest.py (right):

https://codereview.chromium.org/352163003/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/plist_writer_unittest.py:282:
<string>string</string>
On 2014/06/26 08:08:56, Andrew T Wilson wrote:
> On 2014/06/25 16:46:57, Joao da Silva wrote:
> > See the int-enum example below: it's possible to enumerate the valid values
> > here. It'd be cool to do the same for string-enum-list.
> 
> I'm trying really hard not to have to actually test that the output works on
all
> different platforms - that's why I'm trying to make the string-enum-list
output
> look exactly like list output. If I make the change you describe, I'd have to
go
> off and make sure that the resulting template works, and I don't want to do
that
> for this change - the motivation for this change is primarily to enable more
> readable documentation.
> 
> If you're setup to test the output template on my behalf, I'm happy to drive a
> followup CL with this change that you can test.

That's cool, I can do the testing for the followup CL.

[Joao da Silva, 2014-06-26 11:39:02]

Landed as https://code.google.com/p/grit-i18n/source/detail?r=170. I'll close
this issue now; you can roll grit in DEPS to 170 now.