Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 347193005: Makes analyzer strip off a leading path separator (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Makes analyzer strip off a leading path separator When running in chrome paths are absolute. Also makes chrome build work with analyzer on windows. The specific define I ran into was MSVS_OS_BITS, but I'm sure there are more. BUG=383609 TEST=none R=mark@chromium.org

Patch Set 1 #

Patch Set 2 : add special case for windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M pylib/gyp/generator/analyzer.py View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 6 months ago (2014-06-23 17:54:56 UTC) #1
Mark Mentovai
LGTM, I guess
6 years, 6 months ago (2014-06-23 18:17:48 UTC) #2
Mark Mentovai
Landed GYP r1946.
6 years, 6 months ago (2014-06-23 18:18:53 UTC) #3
sky
On 2014/06/23 18:17:48, Mark Mentovai wrote: > LGTM, I guess That 'I guess' sure doesn't ...
6 years, 6 months ago (2014-06-23 18:21:08 UTC) #4
Mark Mentovai
6 years, 6 months ago (2014-06-23 18:23:39 UTC) #5
Well, I’m not sure why there would be an absolute path in here to begin with.
That’s the surprise to me.

Powered by Google App Engine
This is Rietveld 408576698