chrome/browser/guest_view/web_view/javascript_dialog_helper.h - Issue 347113002: Refactor PluginPermissionHelper as WebViewPermissionHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/javascript_dialog_helper.h

Issue 347113002: Refactor PluginPermissionHelper as WebViewPermissionHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests failures. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guest_view/guest_view_base.h ('K') | « chrome/browser/guest_view/guest_view_base.h ('k') | chrome/browser/guest_view/web_view/javascript_dialog_helper.cc » ('j') | chrome/browser/guest_view/web_view/web_view_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/javascript_dialog_helper.h

diff --git a/chrome/browser/guest_view/web_view/javascript_dialog_helper.h b/chrome/browser/guest_view/web_view/javascript_dialog_helper.h

index 94f7374e81a23ba9efbea15026381957280e195a..7f3700264d05d62af24141af7628c696ce41f262 100644

--- a/chrome/browser/guest_view/web_view/javascript_dialog_helper.h

+++ b/chrome/browser/guest_view/web_view/javascript_dialog_helper.h

@@ -45,7 +45,7 @@ class JavaScriptDialogHelper : public content::JavaScriptDialogManager {

const std::string& user_input);

// Pointer to the webview that is being helped.

- WebViewGuest* const webview_guest_;

+ WebViewGuest* const web_view_guest_;

DISALLOW_COPY_AND_ASSIGN(JavaScriptDialogHelper);

};