chrome/browser/guest_view/guest_view_base.h - Issue 347113002: Refactor PluginPermissionHelper as WebViewPermissionHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/guest_view_base.h

Issue 347113002: Refactor PluginPermissionHelper as WebViewPermissionHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests failures. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context_extensions.cc ('k') | chrome/browser/guest_view/web_view/javascript_dialog_helper.h » ('j') | chrome/browser/guest_view/web_view/web_view_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/guest_view_base.h

diff --git a/chrome/browser/guest_view/guest_view_base.h b/chrome/browser/guest_view/guest_view_base.h

index a8b8aa48617d7f787e2005c681e98cbf439bc683..ab169bb469e966c1d8231aa48176ab5234df0d93 100644

--- a/chrome/browser/guest_view/guest_view_base.h

+++ b/chrome/browser/guest_view/guest_view_base.h

@@ -204,15 +204,17 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

content::WebContents* embedder_web_contents,

const base::DictionaryValue& extra_params) OVERRIDE FINAL;

+ // Dispatches an event |event_name| to the embedder with the |event| fields.

+ // Change this function as a public function because WebViewGuest will use it

Fady Samuel 2014/06/27 18:46:07 Remove this part of the comment.

Xi Han 2014/07/03 18:55:58 Done.

+ // to dispatch permission request event.

+ void DispatchEvent(Event* event);

Fady Samuel 2014/06/27 18:46:07 Couple you please rename this to DispatchEventToEm

Xi Han 2014/07/03 18:55:58 Done.

protected:

GuestViewBase(content::BrowserContext* browser_context,

int guest_instance_id);

virtual ~GuestViewBase();

- // Dispatches an event |event_name| to the embedder with the |event| fields.

- void DispatchEvent(Event* event);

private:

class EmbedderWebContentsObserver;