Refactor PluginPermissionHelper as WebViewPermissionHelper

chrome/browser/guest_view/guest_view_base.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_
 #define CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_
 
 #include <queue>
 
 #include "base/memory/weak_ptr.h"
@@ skipping 186 matching lines @@
   // BrowserPluginGuestDelegate implementation.
   virtual void Destroy() OVERRIDE FINAL;
   virtual void DidAttach() OVERRIDE FINAL;
   virtual int GetGuestInstanceID() const OVERRIDE;
   virtual void RegisterDestructionCallback(
       const DestructionCallback& callback) OVERRIDE FINAL;
   virtual void WillAttach(
       content::WebContents* embedder_web_contents,
       const base::DictionaryValue& extra_params) OVERRIDE FINAL;
 
+  // Dispatches an event |event_name| to the embedder with the |event| fields.
+  // Change this function as a public function because WebViewGuest will use it

[Fady Samuel, 2014/06/27 18:46:07]

Remove this part of the comment.

[Xi Han, 2014/07/03 18:55:58]

Done.

+  // to dispatch permission request event.
+  void DispatchEvent(Event* event);

[Fady Samuel, 2014/06/27 18:46:07]

Couple you please rename this to DispatchEventToEmbedder? Thanks!

[Xi Han, 2014/07/03 18:55:58]

Done.

+
  protected:
   GuestViewBase(content::BrowserContext* browser_context,
                 int guest_instance_id);
 
   virtual ~GuestViewBase();
 
-  // Dispatches an event |event_name| to the embedder with the |event| fields.
-  void DispatchEvent(Event* event);
-
  private:
   class EmbedderWebContentsObserver;
 
   void SendQueuedEvents();
 
   void CompleteCreateWebContents(const std::string& embedder_extension_id,
                                  int embedder_render_process_id,
                                  const WebContentsCreatedCallback& callback,
                                  content::WebContents* guest_web_contents);
 
@@ skipping 39 matching lines @@
   scoped_ptr<EmbedderWebContentsObserver> embedder_web_contents_observer_;
 
   // This is used to ensure pending tasks will not fire after this object is
   // destroyed.
   base::WeakPtrFactory<GuestViewBase> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GuestViewBase);
 };
 
 #endif  // CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_