Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 347053007: Ensure we compute the height of replaced elements to 'auto' when appropriate. (Closed)

Created:
6 years, 6 months ago by rhogan
Modified:
6 years, 5 months ago
CC:
andersr, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Ensure we compute the height of replaced elements to 'auto' when appropriate. If a replaced element has a percentage height specified then its height should compute to 'auto' when its containing block does not have a height 'specified explicitly'. We were taking this to mean when its containing block's specified height value is 'auto' - in fact it means when the containing block's computed height is auto. This brings us into line with IE and Firefox. http://lists.w3.org/Archives/Public/www-style/2014Jun/0079.html BUG=385877 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177143

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
A LayoutTests/css2.1/20110323/height-percentage-005.htm View 1 chunk +47 lines, -0 lines 0 comments Download
A LayoutTests/css2.1/20110323/height-percentage-005-expected.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/css2.1/20110323/support/black96x96.png View Binary file 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +5 lines, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
leviw_travelin_and_unemployed
Makes sense to me. LGTM.
6 years, 5 months ago (2014-06-27 19:07:57 UTC) #1
rhogan
The CQ bit was checked by robhogan@gmail.com
6 years, 5 months ago (2014-06-27 21:21:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/347053007/1
6 years, 5 months ago (2014-06-27 21:21:53 UTC) #3
commit-bot: I haz the power
Change committed as 177143
6 years, 5 months ago (2014-06-27 21:52:59 UTC) #4
davve
6 years, 5 months ago (2014-06-30 08:52:38 UTC) #5
Message was sent while issue was closed.
Thanks for working on this!

https://codereview.chromium.org/347053007/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBoxModelObject.cpp (right):

https://codereview.chromium.org/347053007/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBoxModelObject.cpp:193: if
(!cb->style()->logicalTop().isAuto() && !cb->style()->logicalBottom().isAuto())
This line still looks suspect. I filed https://codereview.chromium.org/359673003
and http://code.google.com/p/chromium/issues/detail?id=390101 to investigate.

Powered by Google App Engine
This is Rietveld 408576698