Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 359673003: Inapplicable top, bottom style shouldn't affect height calculation (Closed)

Created:
6 years, 5 months ago by davve
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Inapplicable top, bottom style shouldn't affect height calculation Require an absolute or fixed positioned containing block before examining the containing block top and bottom style values for contributing a non-auto height. Otherwise we'll base the decision on inapplicable values. |top| and |left| only applies to positioned elements: http://www.w3.org/TR/CSS2/visuren.html#propdef-top http://www.w3.org/TR/CSS2/visuren.html#propdef-bottom and only contribute to the element's height (when height is auto) for absolute and fixed positioned elements: http://www.w3.org/TR/CSS2/visudet.html#normal-block http://www.w3.org/TR/CSS2/visudet.html#abs-non-replaced-height BUG=390101 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177374

Patch Set 1 #

Patch Set 2 : Re-add experimentally removed code and fix it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
A LayoutTests/fast/css/replaced-element-ignore-top-bottom.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
davve
6 years, 5 months ago (2014-06-30 09:59:33 UTC) #1
davve
6 years, 5 months ago (2014-07-01 18:55:08 UTC) #2
leviw_travelin_and_unemployed
lgtm Please provide a link to the part of the relevant spec that covers this ...
6 years, 5 months ago (2014-07-01 22:48:15 UTC) #3
davve
On 2014/07/01 22:48:15, leviw wrote: > lgtm > > Please provide a link to the ...
6 years, 5 months ago (2014-07-02 08:19:57 UTC) #4
davve
The CQ bit was checked by davve@opera.com
6 years, 5 months ago (2014-07-02 08:20:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/359673003/20001
6 years, 5 months ago (2014-07-02 08:20:43 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 13:10:56 UTC) #7
Message was sent while issue was closed.
Change committed as 177374

Powered by Google App Engine
This is Rietveld 408576698