Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 347043002: Rework EventSource tests for better Worker test coverage. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rework EventSource tests for better Worker test coverage. Follow on from https://codereview.chromium.org/340363003/ and recast the remaining Document-agnostic EventSource tests to also be usable from a Worker context. R= BUG=386520 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176665

Patch Set 1 #

Patch Set 2 : Move out CORS tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+660 lines, -608 lines) Patch
M LayoutTests/http/tests/eventsource/eventsource-bad-mime-type.html View 1 chunk +3 lines, -43 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-bad-mime-type-expected.txt View 1 chunk +7 lines, -1 line 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-content-type-charset.html View 1 chunk +3 lines, -92 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-content-type-charset-expected.txt View 1 chunk +31 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-eof.html View 1 chunk +3 lines, -47 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-eof-expected.txt View 1 chunk +19 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-events-after-close.html View 1 chunk +3 lines, -34 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-events-after-close-expected.txt View 1 chunk +9 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-parse-event-stream.html View 1 chunk +3 lines, -78 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-parse-event-stream-expected.txt View 1 chunk +23 lines, -12 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-reconnect.html View 1 chunk +3 lines, -79 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-reconnect-during-navigate-crash.html View 1 chunk +4 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-reconnect-expected.txt View 1 chunk +16 lines, -10 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-retry-precision.html View 1 chunk +3 lines, -37 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-retry-precision-expected.txt View 1 chunk +8 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-status-code-states.html View 1 chunk +3 lines, -78 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-status-code-states-expected.txt View 1 chunk +26 lines, -11 lines 0 comments Download
M LayoutTests/http/tests/eventsource/eventsource-url-attribute.html View 1 chunk +2 lines, -20 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-bad-mime-type.js View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-content-type-charset.js View 1 chunk +80 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-eof.js View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-events-after-close.js View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-parse-event-stream.js View 1 chunk +58 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-reconnect.js View 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/script-tests/eventsource-retry-precision.js View 1 chunk +27 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/script-tests/eventsource-status-code-states.js View 3 chunks +17 lines, -26 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/script-tests/eventsource-url-attribute.js View 2 chunks +3 lines, -12 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-bad-mime-type.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-bad-mime-type-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-content-type-charset.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-content-type-charset-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-eof.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-eof-expected.txt View 1 chunk +22 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-events-after-close.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-events-after-close-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-parse-event-stream.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-parse-event-stream-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-reconnect.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-reconnect-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-retry-precision.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-retry-precision-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-status-code-states.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-status-code-states-expected.txt View 1 chunk +29 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/eventsource/workers/eventsource-url-attribute.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/eventsource/workers/eventsource-url-attribute-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sof
Please take a look. Second part covering the remaining EventSource tests - if you want ...
6 years, 6 months ago (2014-06-20 08:09:41 UTC) #1
abarth-chromium
rslgtm
6 years, 6 months ago (2014-06-20 14:53:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/347043002/1
6 years, 6 months ago (2014-06-20 14:53:51 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-20 16:18:07 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 16:45:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/12741)
6 years, 6 months ago (2014-06-20 16:45:05 UTC) #6
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-20 20:08:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/347043002/20001
6 years, 6 months ago (2014-06-20 20:10:32 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-20 23:25:08 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-21 00:39:37 UTC) #10
Message was sent while issue was closed.
Change committed as 176665

Powered by Google App Engine
This is Rietveld 408576698