Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 346923003: Add ActionRunner wrapper for the remaining less used actions (try 2): (Closed)

Created:
6 years, 5 months ago by chrishenry
Modified:
6 years, 5 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add ActionRunner wrapper for the remaining less used actions (try 2): RepaintContinouosly ReloadAction PinchAction ScrollBounceAction Play/Seek/LoopAction (media actions) Changes in try 2: fixed missing change to pinch.js, also revamped documentation for scroll bounce gesture. BUG=361809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282218

Patch Set 1 #

Patch Set 2 : Address review comment + revamp docs on scroll bounce action. #

Patch Set 3 : Rebase and fix one last (new) usage. #

Patch Set 4 : Update unit test to skip test if touch is not supported. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -336 lines) Patch
M tools/perf/measurements/repaint_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/gmail_refresh.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_mobile_sites.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/media_cns_cases.py View 1 chunk +7 lines, -22 lines 0 comments Download
M tools/perf/page_sets/mobile_memory.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/top_25.py View 1 chunk +1 line, -4 lines 0 comments Download
M tools/perf/page_sets/top_desktop_sites_2012Q3.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_pinch_zoom_cases.py View 4 chunks +16 lines, -20 lines 0 comments Download
M tools/perf/page_sets/tough_scheduling_cases.py View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases.py View 1 chunk +12 lines, -38 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner.py View 1 7 chunks +219 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/all_page_actions.py View 1 chunk +2 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/loop.py View 3 chunks +14 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/loop_unittest.py View 3 chunks +4 lines, -16 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/pinch.js View 2 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/pinch.py View 2 chunks +36 lines, -33 lines 0 comments Download
A tools/telemetry/telemetry/page/actions/pinch_unittest.py View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/play.py View 3 chunks +19 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/play_unittest.py View 7 chunks +13 lines, -17 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/reload.py View 1 chunk +0 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/repaint_continuously.py View 2 chunks +8 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll_bounce.js View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll_bounce.py View 2 chunks +51 lines, -66 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/seek.py View 3 chunks +25 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/seek_unittest.py View 4 chunks +7 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
chrishenry
I was able to repro the crash but only on Chrome Shell (doesn't crash on ...
6 years, 5 months ago (2014-06-28 00:03:40 UTC) #1
tonyg
Can we add a unittest that would have triggered the crash? Then the trybots will ...
6 years, 5 months ago (2014-06-28 00:06:06 UTC) #2
chrishenry
On 2014/06/28 00:06:06, tonyg wrote: > Can we add a unittest that would have triggered ...
6 years, 5 months ago (2014-06-30 17:38:25 UTC) #3
chrishenry
Friendly ping? Cheers!
6 years, 5 months ago (2014-07-01 19:35:47 UTC) #4
dtu
lgtm
6 years, 5 months ago (2014-07-02 19:12:39 UTC) #5
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 5 months ago (2014-07-09 17:37:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/346923003/40001
6 years, 5 months ago (2014-07-09 17:38:19 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 20:50:28 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 21:49:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/47369)
6 years, 5 months ago (2014-07-09 21:49:33 UTC) #10
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 5 months ago (2014-07-09 22:59:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/346923003/60001
6 years, 5 months ago (2014-07-09 23:01:40 UTC) #12
commit-bot: I haz the power
Change committed as 282218
6 years, 5 months ago (2014-07-10 02:31:42 UTC) #13
tonyg
6 years, 5 months ago (2014-07-11 14:57:00 UTC) #14
Message was sent while issue was closed.
On 2014/07/10 02:31:42, I haz the power (commit-bot) wrote:
> Change committed as 282218

Hey Chris,

This broke tough_pinch_zoom_cases again. Don't worry, I fixed it up in
https://codereview.chromium.org/383963006/ . But would you mind adding a
unittest that would have caught this?

One idea would be to make page_set_smoke_test.py load a blank page and then call
document.querySelector(selector) for every query selector in all page sets. If
they don't raise an exception, the test passes (they aren't expected to match
anything, this just checks for invalid selectors). WDYT? Other ideas?

Tony

Powered by Google App Engine
This is Rietveld 408576698