tools/perf/page_sets/tough_scheduling_cases.py - Issue 346923003: Add ActionRunner wrapper for the remaining less used actions (try 2):

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/tough_scheduling_cases.py

Issue 346923003: Add ActionRunner wrapper for the remaining less used actions (try 2): (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update unit test to skip test if touch is not supported. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/tough_scheduling_cases.py

diff --git a/tools/perf/page_sets/tough_scheduling_cases.py b/tools/perf/page_sets/tough_scheduling_cases.py

index d814d56b2785ab61111aa31ae3a5315c020e8ab0..89b3e92fab039c5d4623eae93b104e2ab063e78f 100644

--- a/tools/perf/page_sets/tough_scheduling_cases.py

+++ b/tools/perf/page_sets/tough_scheduling_cases.py

@@ -338,7 +338,10 @@ class EmptyTouchHandlerPage(ToughSchedulingCasesPage):

def RunSmoothness(self, action_runner):

if self.bounce:

- action_runner.RunAction(ScrollBounceAction())

+ interaction = action_runner.BeginGestureInteraction(

+ 'ScrollBounceAction', is_smooth=True)

+ action_runner.ScrollBouncePage()

+ interaction.End()

else:

interaction = action_runner.BeginGestureInteraction(

'ScrollAction', is_smooth=True)

@@ -359,7 +362,10 @@ class SynchronizedScrollOffsetPage(ToughSchedulingCasesPage):

page_set=page_set)