Update common.py.utils to be used in Skia repo

Update common.py.utils to be used in Skia repo

BUG=skia:2682
R=rmistry@google.com

Committed: https://skia.googlesource.com/common/+/767bf85

[borenet, 2014-06-23 19:45:31]

Adding Hal, since the next CL will change a lot of code that he wrote to use
these utilities.

https://codereview.chromium.org/346743008/diff/20001/py/utils/find_depot_tool...
File py/utils/find_depot_tools.py (right):

https://codereview.chromium.org/346743008/diff/20001/py/utils/find_depot_tool...
py/utils/find_depot_tools.py:1: # Copyright (c) 2012 The Chromium Authors. All
rights reserved.
This is directly copied from
https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/commo...

https://codereview.chromium.org/346743008/diff/20001/py/utils/git_utils.py
File py/utils/git_utils.py (right):

https://codereview.chromium.org/346743008/diff/20001/py/utils/git_utils.py#ne...
py/utils/git_utils.py:93: class GitBranch(object):
Moved from misc.py with a couple of minor changes.

https://codereview.chromium.org/346743008/diff/20001/py/utils/shell_utils.py
File py/utils/shell_utils.py (right):

https://codereview.chromium.org/346743008/diff/20001/py/utils/shell_utils.py#...
py/utils/shell_utils.py:23: VERBOSE = True
This helps to avoid having to set echo=False in every call of these functions -
especially when some utility module uses them and doesn't pipe the echo
parameter through, eg. git_utils.

[rmistry, 2014-06-24 17:55:44]

https://codereview.chromium.org/346743008/diff/20001/py/utils/find_depot_tool...
File py/utils/find_depot_tools.py (right):

https://codereview.chromium.org/346743008/diff/20001/py/utils/find_depot_tool...
py/utils/find_depot_tools.py:7: imports breakpad.
Please add a comment here:

This is directly copied from
https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/commo...

https://codereview.chromium.org/346743008/diff/20001/py/utils/git_utils.py
File py/utils/git_utils.py (right):

https://codereview.chromium.org/346743008/diff/20001/py/utils/git_utils.py#ne...
py/utils/git_utils.py:93: class GitBranch(object):
On 2014/06/23 19:45:31, borenet wrote:
> Moved from misc.py with a couple of minor changes.

Looks like delete_when_finished and returning the issue number in
commit_and_upload were the differences.

https://codereview.chromium.org/346743008/diff/20001/py/utils/shell_utils.py
File py/utils/shell_utils.py (right):

https://codereview.chromium.org/346743008/diff/20001/py/utils/shell_utils.py#...
py/utils/shell_utils.py:50: def run_async(cmd, echo=None, shell=False):
Why not directly set VERBOSE as the default value "echo=VERBOSE" everywhere?

[borenet, 2014-06-24 18:00:26]

https://codereview.chromium.org/346743008/diff/20001/py/utils/find_depot_tool...
File py/utils/find_depot_tools.py (right):

https://codereview.chromium.org/346743008/diff/20001/py/utils/find_depot_tool...
py/utils/find_depot_tools.py:7: imports breakpad.
On 2014/06/24 17:55:44, rmistry wrote:
> Please add a comment here:
> 
> This is directly copied from
>
https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/commo...

Done.

https://codereview.chromium.org/346743008/diff/20001/py/utils/git_utils.py
File py/utils/git_utils.py (right):

https://codereview.chromium.org/346743008/diff/20001/py/utils/git_utils.py#ne...
py/utils/git_utils.py:93: class GitBranch(object):
On 2014/06/24 17:55:44, rmistry wrote:
> On 2014/06/23 19:45:31, borenet wrote:
> > Moved from misc.py with a couple of minor changes.
> 
> Looks like delete_when_finished and returning the issue number in
> commit_and_upload were the differences.

Yes, sorry that wasn't clearer.

https://codereview.chromium.org/346743008/diff/20001/py/utils/shell_utils.py
File py/utils/shell_utils.py (right):

https://codereview.chromium.org/346743008/diff/20001/py/utils/shell_utils.py#...
py/utils/shell_utils.py:50: def run_async(cmd, echo=None, shell=False):
On 2014/06/24 17:55:44, rmistry wrote:
> Why not directly set VERBOSE as the default value "echo=VERBOSE" everywhere?

Because default parameters are evaluated only once.  So I can't do:

import shell_utils
shell_utils.VERBOSE = False

Because all of the default parameters get set in the import statement.

[rmistry, 2014-06-24 18:16:56]

LGTM

https://codereview.chromium.org/346743008/diff/20001/py/utils/shell_utils.py
File py/utils/shell_utils.py (right):

https://codereview.chromium.org/346743008/diff/20001/py/utils/shell_utils.py#...
py/utils/shell_utils.py:50: def run_async(cmd, echo=None, shell=False):
On 2014/06/24 18:00:26, borenet wrote:
> On 2014/06/24 17:55:44, rmistry wrote:
> > Why not directly set VERBOSE as the default value "echo=VERBOSE" everywhere?
> 
> Because default parameters are evaluated only once.  So I can't do:
> 
> import shell_utils
> shell_utils.VERBOSE = False
> 
> Because all of the default parameters get set in the import statement.

I see, so you want to be able to set it for different calls of this module. This
will work, the built-in logging module would do this better though, since you
can set it off and you can set different verbosity levels. Either way the way
this is right now is fine by me.

[borenet, 2014-06-24 18:21:02]

Committed patchset #3 manually as r767bf85.