Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: py/utils/misc.py

Issue 346743008: Update common.py.utils to be used in Skia repo (Closed) Base URL: https://skia.googlesource.com/common.git@master
Patch Set: comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « py/utils/git_utils.py ('k') | py/utils/shell_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: py/utils/misc.py
diff --git a/py/utils/misc.py b/py/utils/misc.py
index a1bec6a17f1bf8a31cc7e0e5a0f582b3f12b99a1..c3e4dc89108c063e46eb89aa79f4a2b6026d8911 100644
--- a/py/utils/misc.py
+++ b/py/utils/misc.py
@@ -3,13 +3,10 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-""" This module contains miscellaneous tools used by the buildbot scripts. """
+""" This module contains miscellaneous tools. """
import os
-from git_utils import GIT
-import shell_utils
-
# Absolute path to the root of this Skia buildbot checkout.
BUILDBOT_PATH = os.path.realpath(os.path.join(
@@ -93,50 +90,3 @@ class ChDir(object):
if self._verbose:
print 'chdir %s' % self._origin
os.chdir(self._origin)
-
-
-class GitBranch(object):
- """Class to manage git branches.
-
- This class allows one to create a new branch in a repository to make changes,
- then it commits the changes, switches to master branch, and deletes the
- created temporary branch upon exit.
- """
- def __init__(self, branch_name, commit_msg, upload=True, commit_queue=False):
- self._branch_name = branch_name
- self._commit_msg = commit_msg
- self._upload = upload
- self._commit_queue = commit_queue
- self._patch_set = 0
-
- def __enter__(self):
- shell_utils.run([GIT, 'reset', '--hard', 'HEAD'])
- shell_utils.run([GIT, 'checkout', 'master'])
- if self._branch_name in shell_utils.run([GIT, 'branch']):
- shell_utils.run([GIT, 'branch', '-D', self._branch_name])
- shell_utils.run([GIT, 'checkout', '-b', self._branch_name,
- '-t', 'origin/master'])
- return self
-
- def commit_and_upload(self, use_commit_queue=False):
- shell_utils.run([GIT, 'commit', '-a', '-m',
- self._commit_msg])
- upload_cmd = [GIT, 'cl', 'upload', '-f', '--bypass-hooks',
- '--bypass-watchlists']
- self._patch_set += 1
- if self._patch_set > 1:
- upload_cmd.extend(['-t', 'Patch set %d' % self._patch_set])
- if use_commit_queue:
- upload_cmd.append('--use-commit-queue')
- shell_utils.run(upload_cmd)
-
- def __exit__(self, exc_type, _value, _traceback):
- if self._upload:
- # Only upload if no error occurred.
- try:
- if exc_type is None:
- self.commit_and_upload(use_commit_queue=self._commit_queue)
- finally:
- shell_utils.run([GIT, 'checkout', 'master'])
- shell_utils.run([GIT, 'branch', '-D', self._branch_name])
-
« no previous file with comments | « py/utils/git_utils.py ('k') | py/utils/shell_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698