Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 346573002: Revert 278059 "gpu: Add base class for gpu service tests" (Closed)

Created:
6 years, 6 months ago by macourteau
Modified:
6 years, 6 months ago
Reviewers:
no sievers
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 278059 "gpu: Add base class for gpu service tests" Does not compile on Linux GN: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/7304/steps/compile/logs/stdio > gpu: Add base class for gpu service tests > > This allows for properly setting up and tearing down GL bindings. > Before this patch bindings were intialized in unittest_main.cc but also > reinitialized with a different GL version and extension in some > GLES2CmdDecoderTests which leaves room for problems depending on which order > tests happen to run in. > > More importantly, this will allow me to initialize GL bindings with a certain > GL version and extension bindings for some tests. > > Review URL: https://codereview.chromium.org/332303002 TBR=sievers@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -173 lines) Patch
M trunk/src/gpu/command_buffer/common/unittest_main.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/buffer_manager_unittest.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/context_group_unittest.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/feature_info_unittest.cc View 5 chunks +11 lines, -3 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/framebuffer_manager_unittest.cc View 6 chunks +22 lines, -4 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/gpu/command_buffer/service/gpu_service_test.h View 1 chunk +0 lines, -42 lines 0 comments Download
D trunk/src/gpu/command_buffer/service/gpu_service_test.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/gpu_tracer_unittest.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/mailbox_manager_unittest.cc View 5 chunks +12 lines, -21 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/memory_program_cache_unittest.cc View 5 chunks +10 lines, -3 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/program_manager_unittest.cc View 12 chunks +33 lines, -6 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/query_manager_unittest.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/renderbuffer_manager_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/shader_manager_unittest.cc View 3 chunks +13 lines, -2 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/texture_manager_unittest.cc View 12 chunks +23 lines, -10 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/vertex_array_manager_unittest.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/vertex_attrib_manager_unittest.cc View 4 chunks +11 lines, -3 lines 0 comments Download
M trunk/src/gpu/gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
macourteau
6 years, 6 months ago (2014-06-18 14:55:19 UTC) #1
macourteau
6 years, 6 months ago (2014-06-18 14:57:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r278064 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698