Adds the legacy KeyboardEvent.keyCode attribute for extension IMEs.

Adds the legacy KeyboardEvent.keyCode attribute for extension IMEs.
    
The main usage of the keyCode attribute is to supports sending correct
soft key events. On the on-screen keyboard, each key should have the
keyCode attached, e.g. the key on the right side of TAB key, in US
keyboard layout, it has key:'q',code:'KeyQ',keyCode:0x51; while in FR
keyboard layout, it has key:'a',code:'KeyQ',keyCode:0x41.
Another example is for UK extended keyboard layout, the '#' key (at the
backslash key location), it has key:'#',code:'BackSlash',keyCode:0xDE;
while for US keyboard, it has key:'\\',code:'BackSlash',keyCode:0xDC.

A real case that this cl will fix is on FR on-screen keyboard, pressing
Ctrl+A will trigger Ctrl+Q shortcut.

BUG=355261
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278771

[Shu Chen, 2014-06-19 14:09:01]

Can you please review this cl?

kalman@ for API json file change.
nona@ for other change.

[not at google - send to devlin, 2014-06-19 15:57:28]

json lgtm

https://codereview.chromium.org/346513003/diff/40001/chrome/common/extensions...
File chrome/common/extensions/api/input_ime.json (right):

https://codereview.chromium.org/346513003/diff/40001/chrome/common/extensions...
chrome/common/extensions/api/input_ime.json:21: "keyCode": {"type": "integer",
"description": "It holds system- and implementation-dependent numerical code
signifying the unmodified identifier associated with the key pressed."},
s/It holds//

does this relate to the deprecated HTML keyCode? you could mention that.

[Seigo Nonaka, 2014-06-20 03:16:02]

lgtm

lgtm with a nit.

https://codereview.chromium.org/346513003/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/input_method/input_method_engine_interface.h
(right):

https://codereview.chromium.org/346513003/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/input_method_engine_interface.h:12:
#include "ui/events/keycodes/keyboard_codes.h"
nit: Do you need this header in header file? If not, please move to cc file.

[Shu Chen, 2014-06-20 06:11:58]

https://codereview.chromium.org/346513003/diff/40001/chrome/common/extensions...
File chrome/common/extensions/api/input_ime.json (right):

https://codereview.chromium.org/346513003/diff/40001/chrome/common/extensions...
chrome/common/extensions/api/input_ime.json:21: "keyCode": {"type": "integer",
"description": "It holds system- and implementation-dependent numerical code
signifying the unmodified identifier associated with the key pressed."},
On 2014/06/19 15:57:27, kalman wrote:
> s/It holds//
> 
> does this relate to the deprecated HTML keyCode? you could mention that.

Done.

https://codereview.chromium.org/346513003/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/input_method/input_method_engine_interface.h
(right):

https://codereview.chromium.org/346513003/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/input_method_engine_interface.h:12:
#include "ui/events/keycodes/keyboard_codes.h"
On 2014/06/20 03:16:02, Seigo Nonaka wrote:
> nit: Do you need this header in header file? If not, please move to cc file.

Done.

[Shu Chen, 2014-06-20 06:12:22]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2014-06-20 06:13:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shuchen@chromium.org/346513003/80001

[commit-bot: I haz the power, 2014-06-20 10:49:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-20 12:01:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-20 12:01:05]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Shu Chen, 2014-06-20 14:04:25]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2014-06-20 14:04:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shuchen@chromium.org/346513003/100001

[commit-bot: I haz the power, 2014-06-20 17:12:08]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-20 18:17:20]

Change committed as 278771